Issue #14948: Add support for record pattern syntax in ParenPadCheck#15244
Conversation
b758eed to
83d5013
Compare
|
github, generate report |
1 similar comment
|
github, generate report |
|
Report generation failed on phase "make_report", |
|
github, generate report EDIT: Wrong report |
|
github, generate report |
nrmancuso
left a comment
There was a problem hiding this comment.
Very good, thanks for making review easy :) Please resolve conflicts.
|
@mahfouz72 There is a file conflict. |
|
github, generate report |
|
Report generation failed on phase "make_report", |
|
github, generate report |
|
Report generation failed on phase "make_report", |
|
github, generate report |
|
I surprised on out of memory error for ParenPad , I thought it is light Check. If you find reason of this problem please share it. |
|
Something similar happened before in another PR and @rnveach said here it could be having too many violations that's why we ran into memory. That is the only reason I can think of now. Note that the option is base <module name="ParenPad">
<property name="option" value="space"/>
<property name="tokens" value=""/>
</module>patch <module name="ParenPad">
<property name="option" value="space"/>
<property name="tokens" value="RECORD_PATTERN_DEF"/>
</module>
|
|
github, generate report |
|
Report generation failed on phase "make_report", |
This in one of the checks I see OOM in most frequently due to nesting of ASTs in some test inputs and massive number of violations |
|
@rnveach @nrmancuso ping |
closes #14948:
Diff Regression config: https://gist.githubusercontent.com/mahfouz72/afd57aa6e51ca161b7927acd959e5211/raw/9046d995c208dc72ae20f27578851dfbd6057d50/check.xml
Diff Regression patch config: https://gist.githubusercontent.com/mahfouz72/33967bf86e4a29cafa429771b0e95808/raw/9c0a6290200a700c8a363411f8fb577680f70f79/check_patch.xml
Diff Regression projects: https://gist.githubusercontent.com/mahfouz72/a3d0af030c8f5efd0d8a39f2c14750bc/raw/a3424ad9b6f722e5de1a927e3d85e383101b2b93/projects-to-test-on.properties