Skip to content

Issue #14948: Add support for record pattern syntax in ParenPadCheck#15244

Merged
rnveach merged 1 commit into
checkstyle:masterfrom
checkstyle-GSoC25:pattern-pad
Jul 18, 2024
Merged

Issue #14948: Add support for record pattern syntax in ParenPadCheck#15244
rnveach merged 1 commit into
checkstyle:masterfrom
checkstyle-GSoC25:pattern-pad

Conversation

@mahfouz72 mahfouz72 force-pushed the pattern-pad branch 3 times, most recently from b758eed to 83d5013 Compare July 13, 2024 02:19
@mahfouz72

Copy link
Copy Markdown
Member Author

github, generate report

1 similar comment
@mahfouz72

Copy link
Copy Markdown
Member Author

github, generate report

@github-actions

Copy link
Copy Markdown
Contributor

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/9920624278

@mahfouz72

mahfouz72 commented Jul 13, 2024

Copy link
Copy Markdown
Member Author

github, generate report

EDIT: Wrong report

@github-actions

Copy link
Copy Markdown
Contributor

@mahfouz72

Copy link
Copy Markdown
Member Author

github, generate report

@github-actions

Copy link
Copy Markdown
Contributor

@nrmancuso nrmancuso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thanks for making review easy :) Please resolve conflicts.

@rnveach

rnveach commented Jul 13, 2024

Copy link
Copy Markdown
Contributor

@mahfouz72 There is a file conflict.

@mahfouz72

Copy link
Copy Markdown
Member Author

github, generate report

@github-actions

Copy link
Copy Markdown
Contributor

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/9924090074

@mahfouz72

Copy link
Copy Markdown
Member Author

github, generate report

@github-actions

Copy link
Copy Markdown
Contributor

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/9928212690

@romani

romani commented Jul 14, 2024

Copy link
Copy Markdown
Member

github, generate report

@romani

romani commented Jul 14, 2024

Copy link
Copy Markdown
Member

I surprised on out of memory error for ParenPad , I thought it is light Check. If you find reason of this problem please share it.

@mahfouz72

mahfouz72 commented Jul 14, 2024

Copy link
Copy Markdown
Member Author

Something similar happened before in another PR and @rnveach said here it could be having too many violations that's why we ran into memory. That is the only reason I can think of now. Note that the option is space for the current config.
but I still think this is not a good amount of violations won't be that big to cause heap space error.


base

       <module name="ParenPad">
           <property name="option" value="space"/>
           <property name="tokens" value=""/>
       </module>

patch

      <module name="ParenPad">
           <property name="option" value="space"/>     
           <property name="tokens" value="RECORD_PATTERN_DEF"/>
       </module>

<property name="tokens" value=""/> lol this empty string means all not none ? If yes then OOM is expected we have a violation for all tokens to have space after parens. This will be a huge number of violations

@mahfouz72

Copy link
Copy Markdown
Member Author

github, generate report

@github-actions

Copy link
Copy Markdown
Contributor

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/9928997699

@github-actions

Copy link
Copy Markdown
Contributor

@nrmancuso

nrmancuso commented Jul 14, 2024

Copy link
Copy Markdown
Contributor

I surprised on out of memory error for ParenPad , I thought it is light Check. If you find reason of this problem please share it.

This in one of the checks I see OOM in most frequently due to nesting of ASTs in some test inputs and massive number of violations

@mahfouz72

Copy link
Copy Markdown
Member Author

@rnveach @nrmancuso ping

@rnveach rnveach merged commit 7b9d1da into checkstyle:master Jul 18, 2024
@mahfouz72 mahfouz72 deleted the pattern-pad branch May 9, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

Add Check Support for Java 21 Record Pattern : ParenPad

4 participants