github, generate report

github, generate site

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e53d9a2_2024225316/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e53d9a2_2024225316/checks/misc/finalparameters.html#Properties

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e53d9a2_2024233003/reports/diff/index.html

github, generate report

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e53d9a2_2024010200/reports/diff/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e53d9a2_2024010200/reports/diff/checkstyle/index.html#A3 This exception due to record pattern syntax in enhanced for that is no longer compilable syntax. It was in preview and removed in the final release

PS D:\CS\test> cat src/Test.java
import java.util.List;

public class Test {
    void test(Object o) {
        List<Point> points = List.of(new Point(1, 2), new Point(3, 4), new Point(5, 6));
        for (Point(int x, int y): points) {} // Record patterns in for-each loops are not supported at language level '22'
    }
    record Point(int x, int y) { }
}
PS D:\CS\test> javac src/Test.java
src\Test.java:6: error: '.class' expected
        for (Point(int x, int y): points) {} 
                       ^
src\Test.java:6: error: ';' expected
        for (Point(int x, int y): points) {}
                        ^
src\Test.java:6: error: '.class' expected
        for (Point(int x, int y): points) {}
                              ^
src\Test.java:6: error: not a statement
        for (Point(int x, int y): points) {}
                          ^
src\Test.java:6: error: ';' expected
        for (Point(int x, int y): points) {}
                               ^
src\Test.java:6: error: not a statement
        for (Point(int x, int y): points) {}
                                  ^
src\Test.java:6: error: ';' expected
        for (Point(int x, int y): points) {}
                                        ^
7 errors

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e53d9a2_2024010200/reports/diff/checkstyle/index.html#A3 This exception due to record pattern syntax in enhanced for that is no longer compilable syntax. It was in preview and removed in the final release

Please always show this sort of thing via javac.

github, generate site

github, generate site

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/a039101_2024171136/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/a039101_2024171136/checks/misc/finalparameters.html#Properties

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e121551_2024172940/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e121551_2024172940/checks/misc/finalparameters.html#Properties

@romani @nrmancuso
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e53d9a2_2024010200/reports/diff/checkstyle/index.html#A3
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e53d9a2_2024010200/reports/diff/checkstyle/index.html#A8
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e53d9a2_2024010200/reports/diff/checkstyle/index.html#A10
Regression found an exception.

@mahfouz72 Move exception in master to new issue. Our checks should not throw an exception on compilable code.

Edit:
#15166 (comment)

This exception due to record pattern syntax in enhanced for that is no longer compilable syntax. It was in preview and removed in the final release

If it is no longer compilable, why is it still in our repo and still marked as compilable ("Compilable with Java20")? Is this also something we should discuss removing?

Maybe I am not finding all the regressions. I should see regression of:

• Base is default with all tokens, Patch is default with ignoreUnnamedParameters set to true with all tokens (expecting unnamed differences only)
• Base is default with all tokens, Patch is default with ignoreUnnamedParameters set to false with all tokens (expecting no differences)

If it is no longer compilable, why is it still in our repo and still marked as compilable ("Compilable with Java20")? Is this also something we should discuss removing?

I suggested somewhere that we should open an issue to remove the no longer compilable code in our repo. Such code was a preview in some version we supported it but it was removed. So I am good with this as an issue

Edit: I remembered @nrmancuso said as long as we support some syntax it should have an input file. #14961 (comment)

github, generate report

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/22a829d_2024183400/reports/diff/index.html

github, generate report

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/22a829d_2024194022/reports/diff/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/22a829d_2024194022/reports/diff/index.html
Change in exceptions is fine. I am asking more questions outside of this.

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/22a829d_2024183400/reports/diff/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/22a829d_2024183400/reports/diff/openjdk17/index.html#A2
This is an interesting case. Method parameters can't be unnamed, but this file isn't compilable. Pre-java 9 they could use _ as a named method parameter. Point of ignoring property is for Java 21+ projects to use and like I said they can't have a unnamed method parameter, so this behavior seems ok to me.