Issue #15015: Update CatchParameterName format to allow unnamed catch…#15154
Conversation
1ccc4ae to
7334dc4
Compare
|
Github, generate site |
|
Github, generate report |
nrmancuso
left a comment
There was a problem hiding this comment.
Please update documentation (add a bullet point) to mention that we allow underscores for unnamed variables, and update/remove the bullet point that mentions that we do not allow symbols.
nrmancuso
left a comment
There was a problem hiding this comment.
minor item, last from me:
cd342b3 to
de2eefe
Compare
|
Github, generate site |
| * <li>prohibits numbered abbreviations like {@code e1} or {@code t2}</li> | ||
| * <li>prohibits one letter prefixes like {@code pException}</li> | ||
| * <li>prohibits two letter abbreviations like {@code ie} or {@code ee}</li> | ||
| * <li>prohibits any other characters than letters</li> |
There was a problem hiding this comment.
If we are going to remove this then there needs to be something equivalent that mentions the rest of the prohibitions not mentioned above. This statement covered those before.
For example, we don't say $ is prohibited, nor underscores (excluding _ alone), nor numbers. We say numbered abbreviations above, but its not just abbreviations, it is all numbers.
There was a problem hiding this comment.
prohibits any other characters than letters and underscore?
There was a problem hiding this comment.
prohibits any other characters than letters and underscore?
The concern with just saying "underscore" is you have to make sure they understand underscore with anything else is disallowed. It is just a single _ which is allowed.
Truthfully, I think original wording is fine. We say first we allow _. We can say we don't allow anything other than letters. It should be understood it is top to bottom order. Allows overrides the prohibits.
There was a problem hiding this comment.
Truthfully, I think original wording is fine. We say first we allow
_. We can say we don't allow anything other than letters. It should be understood it is top to bottom order. Allows overrides the prohibits.
make sense. Original wording is restored
…amed catch parameters
closes #15015:
Diff Regression config: https://gist.githubusercontent.com/mahfouz72/afd57aa6e51ca161b7927acd959e5211/raw/696b257d7628c4a99328382b0878d6a07a46ff1a/check.xml
Diff Regression projects: https://gist.githubusercontent.com/mahfouz72/a3d0af030c8f5efd0d8a39f2c14750bc/raw/8ca3493f88bc1003db86b40015a4c2101ab7bc94/projects-to-test-on.properties