Issue #15016: Remove underscore from illegal identifers format#15117
Conversation
|
Github, generate site |
| * that are restricted or contextual keywords. Examples include "yield", "record", and | ||
| * "var". Please read more at | ||
| * <a href="https://docs.oracle.com/javase/specs/jls/se14/html/jls-3.html#jls-3.9"> | ||
| * <a href="https://docs.oracle.com/javase/specs/jls/se22/html/jls-3.html#jls-3.9"> |
There was a problem hiding this comment.
@mahfouz72 @nrmancuso What do you guys think of making this an issue? Finding all old JLS and moving them to 22.
There was a problem hiding this comment.
Good idea I am ok with this it can be a separate issue to keep tacker of all checks or I can update it in other PRs (normal updates) whenever I see an old link in the doc
I think a separate issue would be better
There was a problem hiding this comment.
But does updating links add value? I think most of the links either 22 or 14 will have no difference in the content. there will be a difference ofc in links related to the new syntax (patterns and switch)
There was a problem hiding this comment.
Yes, new issue. Value is ensuring we have no old document links. I am not saying it is a must right now.
There was a problem hiding this comment.
@rnveach you can create an issue for this, but we will not cover it during GSOC.
0a14aba to
b3190d5
Compare
177cdea to
9dbfe23
Compare
|
@nrmancuso Please see #15117 (comment) and merge this when you are ready. |
closes #15016 :
Diff Regression config: https://gist.githubusercontent.com/mahfouz72/afd57aa6e51ca161b7927acd959e5211/raw/ecdaf1a2931b1a7d14f2d0c6d68993923bbc0c91/check.xml
Diff Regression projects: https://gist.githubusercontent.com/mahfouz72/a3d0af030c8f5efd0d8a39f2c14750bc/raw/8ca3493f88bc1003db86b40015a4c2101ab7bc94/projects-to-test-on.properties