Skip to content

infra: change reason of spotbugs disablement in circleci#14863

Merged
romani merged 1 commit into
checkstyle:masterfrom
romani:enable-spotbugs
May 7, 2024
Merged

infra: change reason of spotbugs disablement in circleci#14863
romani merged 1 commit into
checkstyle:masterfrom
romani:enable-spotbugs

Conversation

@romani

@romani romani commented May 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

enablement based on request at spotbugs/spotbugs#2819 (comment)

UPDATE: disablement is staying, reason is changing.

@romani romani mentioned this pull request May 6, 2024
Closed
@romani romani force-pushed the enable-spotbugs branch from f8ffede to af33502 Compare May 6, 2024 13:18
@rnveach

rnveach commented May 6, 2024

Copy link
Copy Markdown
Contributor 
[INFO] Total bugs: 23
[ERROR] Low: Method com.puppycrawl.tools.checkstyle.DetailNodeTreeStringPrinter.parseJavadocAsDetailNode(DetailAST) appears to call the same method on the same object redundantly [com.puppycrawl.tools.checkstyle.DetailNodeTreeStringPrinter] At DetailNodeTreeStringPrinter.java:[line 70] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS
[ERROR] Low: Method com.puppycrawl.tools.checkstyle.JavaAstVisitor.addLastSibling(DetailAstImpl, DetailAstImpl) appears to call the same method on the same object redundantly [com.puppycrawl.tools.checkstyle.JavaAstVisitor] At JavaAstVisitor.java:[line 2377] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS
[ERROR] Low: Method com.puppycrawl.tools.checkstyle.JavaAstVisitor.visitAnnotationField(JavaLanguageParser$AnnotationFieldContext) appears to call the same method on the same object redundantly [com.puppycrawl.tools.checkstyle.JavaAstVisitor] At JavaAstVisitor.java:[line 822] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS
[ERROR] Low: Method com.puppycrawl.tools.checkstyle.JavaAstVisitor.visitFieldDeclaration(JavaLanguageParser$FieldDeclarationContext) appears to call the same method on the same object redundantly [com.puppycrawl.tools.checkstyle.JavaAstVisitor] At JavaAstVisitor.java:[line 464] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS
[ERROR] Low: Method com.puppycrawl.tools.checkstyle.JavaAstVisitor.visitSuperExp(JavaLanguageParser$SuperExpContext) appears to call the same method on the same object redundantly [com.puppycrawl.tools.checkstyle.JavaAstVisitor] At JavaAstVisitor.java:[line 1350] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS
[ERROR] Low: Method com.puppycrawl.tools.checkstyle.JavaAstVisitor$DetailAstPair.advanceChildToEnd() appears to call the same method on the same object redundantly [com.puppycrawl.tools.checkstyle.JavaAstVisitor$DetailAstPair] At JavaAstVisitor.java:[line 2430] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS
[ERROR] Medium: Method com.puppycrawl.tools.checkstyle.Main.main(String[]) has abnormal exit from finally block [com.puppycrawl.tools.checkstyle.Main] At Main.java:[line 155] AFBR_ABNORMAL_FINALLY_BLOCK_RETURN
[ERROR] Medium: Method com.puppycrawl.tools.checkstyle.Main.runCheckstyle(Main$CliOptions, List) has abnormal exit from finally block [com.puppycrawl.tools.checkstyle.Main] At Main.java:[line 419] AFBR_ABNORMAL_FINALLY_BLOCK_RETURN
[ERROR] Medium: Method com.puppycrawl.tools.checkstyle.ant.CheckstyleAntTask.execute() has abnormal exit from finally block [com.puppycrawl.tools.checkstyle.ant.CheckstyleAntTask] At CheckstyleAntTask.java:[line 286] AFBR_ABNORMAL_FINALLY_BLOCK_RETURN
[ERROR] Medium: Method com.puppycrawl.tools.checkstyle.ant.CheckstyleAntTask.realExecute(String) has abnormal exit from finally block [com.puppycrawl.tools.checkstyle.ant.CheckstyleAntTask] At CheckstyleAntTask.java:[line 315] AFBR_ABNORMAL_FINALLY_BLOCK_RETURN
[ERROR] Medium: Method com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck.visitToken(DetailAST) is excessively complex, with a cyclomatic complexity of 51 [com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck] In FinalLocalVariableCheck.java CC_CYCLOMATIC_COMPLEXITY
[ERROR] Medium: Method com.puppycrawl.tools.checkstyle.checks.coding.RequireThisCheck.getClassFrameWhereViolationIsFound(DetailAST) is excessively complex, with a cyclomatic complexity of 56 [com.puppycrawl.tools.checkstyle.checks.coding.RequireThisCheck] In RequireThisCheck.java CC_CYCLOMATIC_COMPLEXITY
[ERROR] Low: Method com.puppycrawl.tools.checkstyle.checks.indentation.BlockParentHandler.getChildrenExpectedIndent() appears to call the same method on the same object redundantly [com.puppycrawl.tools.checkstyle.checks.indentation.BlockParentHandler] At BlockParentHandler.java:[line 279] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS
[ERROR] Low: Method com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractJavadocCheck.visitToken(DetailAST) appears to call the same method on the same object redundantly [com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractJavadocCheck] At AbstractJavadocCheck.java:[line 338] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS
[ERROR] Medium: Method com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.findTokensInAstByType(DetailAST, int) does not presize the allocation of a collection [com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck] At JavadocMethodCheck.java:[line 740] PSC_PRESIZE_COLLECTIONS
[ERROR] Medium: Method com.puppycrawl.tools.checkstyle.gui.ListToTreeSelectionModelWrapper.updateSelectedPathsFromSelectedRows() has abnormal exit from finally block [com.puppycrawl.tools.checkstyle.gui.ListToTreeSelectionModelWrapper] At ListToTreeSelectionModelWrapper.java:[line 111] AFBR_ABNORMAL_FINALLY_BLOCK_RETURN
[ERROR] High: Nullcheck of files at line 95 of value previously dereferenced in com.puppycrawl.tools.checkstyle.meta.MetadataGeneratorUtil.getTargetFiles(String, String[]) [com.puppycrawl.tools.checkstyle.meta.MetadataGeneratorUtil, com.puppycrawl.tools.checkstyle.meta.MetadataGeneratorUtil] At MetadataGeneratorUtil.java:[line 95]Redundant null check at MetadataGeneratorUtil.java:[line 103] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE
[ERROR] Low: Method com.puppycrawl.tools.checkstyle.meta.XmlMetaWriter.writeToFile(Document, ModuleDetails) appears to call the same method on the same object redundantly [com.puppycrawl.tools.checkstyle.meta.XmlMetaWriter] At XmlMetaWriter.java:[line 164] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS
[ERROR] High: Nullcheck of stream at line 1101 of value previously dereferenced in com.puppycrawl.tools.checkstyle.site.SiteUtil.getIntArrayPropertyValue(Object) [com.puppycrawl.tools.checkstyle.site.SiteUtil, com.puppycrawl.tools.checkstyle.site.SiteUtil] At SiteUtil.java:[line 1101]Redundant null check at SiteUtil.java:[line 1108] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE
[ERROR] High: Nullcheck of valuesStream at line 1056 of value previously dereferenced in com.puppycrawl.tools.checkstyle.site.SiteUtil.getStringArrayPropertyValue(String, Object) [com.puppycrawl.tools.checkstyle.site.SiteUtil, com.puppycrawl.tools.checkstyle.site.SiteUtil] At SiteUtil.java:[line 1056]Redundant null check at SiteUtil.java:[line 1059] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE
[ERROR] High: Nullcheck of stream at line 511 of value previously dereferenced in com.puppycrawl.tools.checkstyle.site.SiteUtil.getXdocsTemplatesFilePaths() [com.puppycrawl.tools.checkstyle.site.SiteUtil, com.puppycrawl.tools.checkstyle.site.SiteUtil] At SiteUtil.java:[line 511]Redundant null check at SiteUtil.java:[line 512] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE
[ERROR] Low: Method com.puppycrawl.tools.checkstyle.utils.JavadocUtil.getJavadocTags(TextBlock, JavadocUtil$JavadocTagType) appears to call the same method on the same object redundantly [com.puppycrawl.tools.checkstyle.utils.JavadocUtil] At JavadocUtil.java:[line 119] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS
[ERROR] Low: Method com.puppycrawl.tools.checkstyle.utils.JavadocUtil.getJavadocTags(TextBlock, JavadocUtil$JavadocTagType) appears to call the same method on the same object redundantly [com.puppycrawl.tools.checkstyle.utils.JavadocUtil] At JavadocUtil.java:[line 123] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS

@romani

romani commented May 7, 2024

Copy link
Copy Markdown
Member Author

It not clear why we have such violations, over CIs are not reporting them. If them are false positives, we need to report them to spot bugs team

@romani

romani commented May 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

I have the same 23 problems on my local.
Other CIs are green - https://dev.azure.com/romanivanovjr/romanivanovjr/_build/results?buildId=21349&view=logs&j=e663805c-ee13-5a24-f979-d725e0346c8e&t=40ff6e43-c5d7-5753-f947-23012624b0c6&l=1843

mvn verify on my local is 0 violations.

I reported spotbugs/spotbugs-maven-plugin#806

@romani romani mentioned this pull request May 7, 2024
Open
@romani romani force-pushed the enable-spotbugs branch from af33502 to dcaf033 Compare May 7, 2024 13:01
@romani romani changed the title infra: enable spotbugs in circleci infra: change reason of spotbugs disablement in circleci May 7, 2024
@romani

romani commented May 7, 2024

Copy link
Copy Markdown
Member Author

we will continue to keep disablement until new issue is resolved.
most(maybe all) violations are false positives.

@nrmancuso nrmancuso assigned romani and unassigned nrmancuso May 7, 2024
@romani romani merged commit 5071019 into checkstyle:master May 7, 2024
@romani romani deleted the enable-spotbugs branch May 7, 2024 15:21
@AmitKumarDeoghoria AmitKumarDeoghoria mentioned this pull request Mar 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nrmancuso nrmancuso nrmancuso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@romani romani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@romani @rnveach @nrmancuso