Skip to content

Issue #14625: fix inspection violations OptionalGetWithoutIsPresent#14827

Merged
nrmancuso merged 1 commit into
checkstyle:masterfrom
MANISH-K-07:fixIdea5
Apr 27, 2024
Merged

Issue #14625: fix inspection violations OptionalGetWithoutIsPresent#14827
nrmancuso merged 1 commit into
checkstyle:masterfrom
MANISH-K-07:fixIdea5

Conversation

@MANISH-K-07

@MANISH-K-07 MANISH-K-07 commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

@MANISH-K-07

This comment was marked as resolved.

@MANISH-K-07

Copy link
Copy Markdown
Contributor Author

From #14811 (comment) ,

@romani , If the changes of this PR are approved, then I will proceed with other violations concerning this inspection. (there are a lot more)

@MANISH-K-07 we will probably not be able to take a generic approach to this inspection unless all violations are in test classes. Any that are in test classes can be sent in one PR

@nrmancuso , all the problems were from test classes only :)

Inspections result :
https://app.circleci.com/pipelines/github/checkstyle/checkstyle/25320/workflows/4f52a9d3-0f1e-4257-9a10-7224cbd8aac6/jobs/581265?invite=true#step-103-4471_36

@nrmancuso nrmancuso self-assigned this Apr 24, 2024
@nrmancuso nrmancuso self-requested a review April 24, 2024 10:38

@nrmancuso nrmancuso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@nrmancuso nrmancuso merged commit 10908a4 into checkstyle:master Apr 27, 2024
@MANISH-K-07 MANISH-K-07 deleted the fixIdea5 branch April 27, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants