Skip to content

Issue #14556: Bump Codenarc version to highest compatible release v2.2.0#14558

Merged
nrmancuso merged 1 commit into
checkstyle:masterfrom
MANISH-K-07:codenarc
Feb 28, 2024
Merged

Issue #14556: Bump Codenarc version to highest compatible release v2.2.0#14558
nrmancuso merged 1 commit into
checkstyle:masterfrom
MANISH-K-07:codenarc

Conversation

@MANISH-K-07

@MANISH-K-07 MANISH-K-07 commented Feb 27, 2024

Copy link
Copy Markdown
Contributor

Closes #14556

Extension of Issue checkstyle/contribution#757 and response to checkstyle/contribution#757 (comment)

CodeNarc release used : v2.2.0
Link to page : https://github.com/CodeNarc/CodeNarc/releases

Verified changes on local :

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:56 h
[INFO] Finished at: 2024-02-27T12:17:22+05:30
[INFO] ------------------------------------------------------------------------

@MANISH-K-07 MANISH-K-07 mentioned this pull request Feb 27, 2024
Closed
@MANISH-K-07

MANISH-K-07 commented Feb 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@romani , @nrmancuso

The failing CI are unrelated, I believe.

Check PR Description / Analyze (pull_request) failing due to PR linked to non-approved issue.

@MANISH-K-07 MANISH-K-07 mentioned this pull request Feb 27, 2024
Closed
@nrmancuso

nrmancuso commented Feb 27, 2024

Copy link
Copy Markdown
Contributor

@MANISH-K-07 issue is approved, please link to successful codenarc execution in CI

@MANISH-K-07

MANISH-K-07 commented Feb 27, 2024

Copy link
Copy Markdown
Contributor Author

@MANISH-K-07 issue is approved, please link to successful codenarc execution in CI

@nrmancuso ,
As per my knowledge of checkstyle codebase so far, codenarc validation in ci of main repo is a part of Semaphore.

In file semaphore.yml :

        - name: codenarc analysis
          commands:
            - rm -rf $HOME/.m2
            - ./.ci/codenarc.sh

not sure why but I am unable to view the build log of ci/semaphore.
However, ci/semaphoreci/pr: Checkstyle CI pipeline on Semaphore — The build passed on Semaphore 2.0.
If this isn't enough proof, Can anything be done to obtain the raw log ?

romani
romani approved these changes Feb 28, 2024
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani requested a review from nrmancuso February 28, 2024 02:14
@nrmancuso

nrmancuso commented Feb 28, 2024

Copy link
Copy Markdown
Contributor

not sure why but I am unable to view the build log of ci/semaphore.

Just checked, seems like you may not be able to without an org login. Here is a screenshot of the UI:

image

@nrmancuso nrmancuso merged commit 79c3683 into checkstyle:master Feb 28, 2024
@MANISH-K-07 MANISH-K-07 deleted the codenarc branch February 28, 2024 07:52
@MANISH-K-07 MANISH-K-07 mentioned this pull request Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

+1 more reviewer

@nrmancuso nrmancuso nrmancuso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nrmancuso nrmancuso

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Codenarc to highest compatible release - v2.2.0

3 participants

@MANISH-K-07 @nrmancuso @romani