Skip to content

Issue #13345: Enable TestCases for GenericWhitespaceCheckExamplesTest#14364

Closed
chrccl wants to merge 1 commit into
checkstyle:masterfrom
chrccl:enable-generic-whitespace-check-test
Closed

Issue #13345: Enable TestCases for GenericWhitespaceCheckExamplesTest#14364
chrccl wants to merge 1 commit into
checkstyle:masterfrom
chrccl:enable-generic-whitespace-check-test

Conversation

@chrccl

@chrccl chrccl commented Jan 27, 2024

Copy link
Copy Markdown
Contributor

Issue #13345: Enable TestCases for GenericWhitespaceCheckExamplesTest

@chrccl chrccl force-pushed the enable-generic-whitespace-check-test branch from 376c704 to 5173ee6 Compare January 27, 2024 13:47
@chrccl

chrccl commented Jan 27, 2024

Copy link
Copy Markdown
Contributor Author

Good Morning @romani ! Sorry, I had to close the previous PR for some strange error (It could not update it with another commit). I've done your reviews... But now I have some failed checks. Can you please help me? I'm struggling with this issue.

nrmancuso
nrmancuso suggested changes Jan 29, 2024
View reviewed changes

@nrmancuso nrmancuso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items:

Comment thread .../resources/com/puppycrawl/tools/checkstyle/checks/whitespace/genericwhitespace/Example1.java Outdated
Comment thread .../resources/com/puppycrawl/tools/checkstyle/checks/whitespace/genericwhitespace/Example1.java Outdated
Comment thread .../resources/com/puppycrawl/tools/checkstyle/checks/whitespace/genericwhitespace/Example1.java
Comment thread .../resources/com/puppycrawl/tools/checkstyle/checks/whitespace/genericwhitespace/Example1.java
Comment thread .../resources/com/puppycrawl/tools/checkstyle/checks/whitespace/genericwhitespace/Example1.java Outdated
Comment thread .../resources/com/puppycrawl/tools/checkstyle/checks/whitespace/genericwhitespace/Example1.java
Comment thread .../resources/com/puppycrawl/tools/checkstyle/checks/whitespace/genericwhitespace/Example1.java Outdated
Comment thread src/xdocs/checks/whitespace/genericwhitespace.xml.template Outdated
Comment thread .../resources/com/puppycrawl/tools/checkstyle/checks/whitespace/genericwhitespace/Example1.java
Comment thread .../resources/com/puppycrawl/tools/checkstyle/checks/whitespace/genericwhitespace/Example1.java Outdated
@nrmancuso nrmancuso self-assigned this Jan 29, 2024
@nrmancuso nrmancuso requested a review from rnveach January 29, 2024 04:54
@chrccl chrccl force-pushed the enable-generic-whitespace-check-test branch from 0f5f5b1 to 6942edf Compare February 8, 2024 17:10
@chrccl

chrccl commented Feb 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hey @nrmancuso @rnveach ,

Hope you're doing awesome! 🌟
Sorry for the silence – got caught up in the uni whirlwind. 🎓 But good news: I've tackled all the tweaks you wanted for the project!
Would love your thoughts on what's next. Any guidance from your end would be golden. How can I solve these last checks?🙌
Thanks a ton for your patience!

@chrccl chrccl requested a review from nrmancuso February 9, 2024 08:40
@romani romani force-pushed the enable-generic-whitespace-check-test branch from 6942edf to 5513413 Compare February 9, 2024 13:57
@romani

romani commented Feb 9, 2024

Copy link
Copy Markdown
Member

GitHub, generate website

@github-actions

github-actions Bot commented Feb 9, 2024

Copy link
Copy Markdown
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/5513413_2024143701/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/5513413_2024143701/checks/whitespace/genericwhitespace.html#Example1-code

romani
romani approved these changes Feb 9, 2024
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge

@sktpy sktpy mentioned this pull request Feb 10, 2024
Closed
@chrccl

chrccl commented Feb 12, 2024

Copy link
Copy Markdown
Contributor Author

ok to merge

@romani ping

nrmancuso
nrmancuso suggested changes Feb 12, 2024
View reviewed changes

@nrmancuso nrmancuso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#14364 (comment)

@chrccl chrccl force-pushed the enable-generic-whitespace-check-test branch 10 times, most recently from 49756d3 to fefaa01 Compare February 12, 2024 14:50
@chrccl chrccl requested a review from nrmancuso February 12, 2024 16:00
@chrccl

chrccl commented Feb 13, 2024

Copy link
Copy Markdown
Contributor Author

#14364 (comment)

Morning sir @nrmancuso, please check now.

@chrccl

chrccl commented Feb 14, 2024

Copy link
Copy Markdown
Contributor Author

@romani @nrmancuso ping

@romani

romani commented Feb 14, 2024

Copy link
Copy Markdown
Member

@chrccl , please switch to another issue or fixes we will handle this PR soon.

@romani romani force-pushed the enable-generic-whitespace-check-test branch from fefaa01 to 47cf1af Compare February 14, 2024 13:44
@romani

romani commented Feb 14, 2024

Copy link
Copy Markdown
Member

GitHub, generate website

@chrccl chrccl force-pushed the enable-generic-whitespace-check-test branch 4 times, most recently from a732900 to 11e812a Compare February 14, 2024 14:29
@chrccl

chrccl commented Feb 14, 2024

Copy link
Copy Markdown
Contributor Author

@chrccl , please switch to another issue or fixes we will handle this PR soon.

ok, sorry I read this message only after my last push... Sorry for the mess I created! I'm confident that with the upcoming issues, I will improve and contribute better to the project!!!

@romani

romani commented Feb 14, 2024

Copy link
Copy Markdown
Member

@chrccl, please rebase on our latest code in master branch.
Please address failing CI https://dev.azure.com/romanivanovjr/romanivanovjr/_build/results?buildId=19707&view=logs&jobId=e663805c-ee13-5a24-f979-d725e0346c8e&j=e663805c-ee13-5a24-f979-d725e0346c8e&t=40ff6e43-c5d7-5753-f947-23012624b0c6

nrmancuso
nrmancuso suggested changes Feb 15, 2024
View reviewed changes

@nrmancuso nrmancuso left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to complete this item, somehow we now lost all diamond operators after your last push. https://github.com/checkstyle/checkstyle/pull/14364/files#r1489472956

@chrccl chrccl force-pushed the enable-generic-whitespace-check-test branch 2 times, most recently from 74c6a4e to b356f9f Compare February 15, 2024 15:25
@chrccl chrccl requested a review from nrmancuso February 15, 2024 15:27
@chrccl chrccl force-pushed the enable-generic-whitespace-check-test branch from b356f9f to cef396c Compare February 16, 2024 16:11
@chrccl chrccl requested a review from romani February 17, 2024 11:17
@romani

romani commented Feb 17, 2024

Copy link
Copy Markdown
Member

GitHub, generate website

@github-actions

github-actions Bot commented Feb 17, 2024

Copy link
Copy Markdown
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/cef396c_2024160851/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/cef396c_2024160851/checks/whitespace/genericwhitespace.html#Example1-code

sktpy
sktpy reviewed Feb 22, 2024
View reviewed changes
Comment thread .../resources/com/puppycrawl/tools/checkstyle/checks/whitespace/genericwhitespace/Example1.java

// Generic constructor call
MyClass<String, String> obj = new MyClass<String, String>();
List a = new ArrayList<> (); // ok, until #14344

@sktpy sktpy Feb 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrccl Fix is merged, you can update this input and the corresponding test to have a violation here.

@sktpy sktpy mentioned this pull request Feb 23, 2024
Merged
@nrmancuso nrmancuso removed their assignment Mar 11, 2024
@romani

romani commented Mar 16, 2024

Copy link
Copy Markdown
Member

if no respnse in 2 weeks, PR will be marked as abandoned and might be closed.

@romani

romani commented Oct 18, 2024

Copy link
Copy Markdown
Member

Merged at #14529

@romani romani closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rnveach rnveach Awaiting requested review from rnveach

@nrmancuso nrmancuso Awaiting requested review from nrmancuso

@romani romani Awaiting requested review from romani

1 more reviewer

@sktpy sktpy sktpy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting changes awaiting response

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chrccl @romani @nrmancuso @sktpy