minor: Rename static variable in UnusedLocalVar check to make more sense#14090
Closed
Vyom-Yadav wants to merge 1 commit intocheckstyle:masterfrom
Closed
minor: Rename static variable in UnusedLocalVar check to make more sense#14090Vyom-Yadav wants to merge 1 commit intocheckstyle:masterfrom
Vyom-Yadav wants to merge 1 commit intocheckstyle:masterfrom
Conversation
Member
|
Spelling |
3f9b509 to
e068530
Compare
Member
Author
Done |
nrmancuso
suggested changes
Dec 9, 2023
| * An array of blocks in which local anon inner classes can exist. | ||
| */ | ||
| private static final int[] CONTAINERS_FOR_ANON_INNERS = { | ||
| private static final int[] TYPEDECL_BODY_DECLARATION_TOKENS = { |
Contributor
There was a problem hiding this comment.
Suggested change
| private static final int[] TYPEDECL_BODY_DECLARATION_TOKENS = { | |
| private static final int[] ANONYMOUS_CLASS_PARENT_TOKENS = { |
Please do this, we can avoid extension of spelling list, and this is more obvious in the context of a check.
Member
|
Moved to #15158 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally posted by @nrmancuso in #13543 (comment)