Issue #14014: Ignore left curly in line wrapping indentation handler#14024
Issue #14014: Ignore left curly in line wrapping indentation handler#14024rnveach merged 3 commits intocheckstyle:masterfrom
Conversation
|
Good. Example on how we do this: #13424 but you need config with indentation check only. There are more examples in PRs. |
|
GitHub, generate report |
nrmancuso
left a comment
There was a problem hiding this comment.
Please do:
- Generate another regression report using the module at https://checkstyle.sourceforge.io/checks/misc/indentation.html#Example3-config
- Create new test/test input using exact configuration and code from issue report, also showing violations on under-indented
{
|
GitHub, generate report |
|
forceStrictCondition=true: |
9ee4718 to
a9d01fe
Compare
nrmancuso
left a comment
There was a problem hiding this comment.
Awesome, thanks a lot for your contribution!
|
@jungm , as we going close to merge, please let me know if you need this fix to be released after merge. We can trigger release. |
|
@romani a release would be awesome! |
|
@jungm , thanks a lot for fix do not hesitate to send more PRs with fixes :) . |
This fixes #14014
Diff Regression config: https://gist.githubusercontent.com/jungm/22d6a6a07b5505de2abadc3f68f9e418/raw/697705cfa8a06a514d5c163746de8a7c40391923/config.xml
Report label: forceStrictCondition=true