Issue #13770: Override write func to enforce unix-style newline#13947
Merged
Conversation
32acffc to
e0b86c0
Compare
Member
|
Please test this commit in other PR to make sure it works this time |
e0b86c0 to
d367802
Compare
nrmancuso
suggested changes
Oct 24, 2023
nrmancuso
left a comment
Contributor
There was a problem hiding this comment.
Please share a link to successful CI execution in other PR in the PR description here.
Items:
2a3d741 to
cec6cb3
Compare
Member
|
@michael-o , are we doing it in right way? |
michael-o
approved these changes
Oct 24, 2023
michael-o
left a comment
Contributor
There was a problem hiding this comment.
Looks OK to me. Maybe a test would be good.
Contributor
Author
We have just verified it by cherry picking it in the other PR. https://ci.appveyor.com/project/Checkstyle/checkstyle/builds/48355264 |
Member
|
Yes, CI will catch this. |
Contributor
Author
|
I will fix the lock tainting error tomorrow morning. |
Member
cec6cb3 to
1b104bc
Compare
Contributor
Author
|
Finally we can close this! Let's merge all CI green! |
1b104bc to
3a754f2
Compare
nrmancuso
approved these changes
Oct 25, 2023
Contributor
|
@kalpadiptyaroy please rebase other PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Issue #13770: PR #13774 has a bug, to resolve that we are overriding the
writefunc of PrinterWriter as well to make it concrete.Proof of Validity - https://ci.appveyor.com/project/Checkstyle/checkstyle/builds/48355264