Skip to content

Issue #13809: Kill mutation in PackageObjectFactory-2#13927

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:PackageObjectFactory2
Nov 6, 2023
Merged

Issue #13809: Kill mutation in PackageObjectFactory-2#13927
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:PackageObjectFactory2

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Oct 22, 2023 •
edited
Loading

Issue #13809: Kill mutation in PackageObjectFactory-2

Test added

romani
romani requested changes Oct 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

@romani romani self-assigned this Oct 22, 2023
@Kevin222004 Kevin222004 mentioned this pull request Oct 24, 2023
Closed
33 tasks
@Kevin222004 Kevin222004 force-pushed the PackageObjectFactory2 branch from c4643c2 to 06467dc Compare October 30, 2023 18:04
@romani
Copy link
Copy Markdown
Member

romani commented Oct 31, 2023 •
edited
Loading

CI failure
[ERROR] AllTestsTest.testAllInputsHaveTest:60->walk:87->lambda$testAllInputsHaveTest$1:61->verifyInputFile:156 Resource must start with 'Input' or 'Expected': com/puppycrawl/tools/checkstyle/packageobjectfactory/zoo/FooCheck.java expected to be true

Looks like you need register new test packages at

checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/internal/AllTestsTest.java

Lines 146 to 149 in 8f9c514

// until https://github.com/checkstyle/checkstyle/issues/5105
if (!path.contains(File.separatorChar + "grammar" + File.separatorChar)
&& !path.contains(File.separatorChar + "foo" + File.separatorChar)
&& !path.contains(File.separatorChar + "bar" + File.separatorChar)) {

@Kevin222004 Kevin222004 force-pushed the PackageObjectFactory2 branch from 06467dc to 4c899c6 Compare October 31, 2023 06:11
@romani
Copy link
Copy Markdown
Member

romani commented Oct 31, 2023 •
edited
Loading

[ERROR] [checkstyle] [ERROR] C:\projects\checkstyle\src\test\java\com\puppycrawl\tools\checkstyle\internal\AllTestsTest.java:135:5: Cyclomatic Complexity is 12 (max allowed is 10). [CyclomaticComplexity]

Move IF expression to separate method

@Kevin222004 Kevin222004 force-pushed the PackageObjectFactory2 branch from 4c899c6 to f2ffd5b Compare November 3, 2023 17:52
@romani
Copy link
Copy Markdown
Member

romani commented Nov 5, 2023

@Kevin222004 , https://app.circleci.com/pipelines/github/checkstyle/checkstyle/21670/workflows/be13b9cb-73b2-4cc3-95c9-656f114fd5eb/jobs/421997/artifacts

@Kevin222004 Kevin222004 force-pushed the PackageObjectFactory2 branch from f2ffd5b to 53898c3 Compare November 5, 2023 14:53
romani
romani approved these changes Nov 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge as CI pass.
Pitest was restarted.

@romani romani merged commit 825a9f8 into checkstyle:master Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

@romani romani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kevin222004 @romani