Skip to content

Issue #13809: Kill mutation in Checker-4#13914

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:checker4
Oct 20, 2023
Merged

Issue #13809: Kill mutation in Checker-4#13914
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:checker4

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Oct 19, 2023

Issue #13809: Kill mutation in Checker-4

Mutation

checkstyle/config/pitest-suppressions/pitest-common-suppressions.xml

Lines 30 to 38 in 8c8bc0c

<mutation unstable="false">
<sourceFile>Checker.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.Checker</mutatedClass>
<mutatedMethod>processFile</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/io/IOException::getMessage</description>
<lineContent>new String[] {ioe.getMessage()}, null, getClass(), null));</lineContent>
</mutation>

Explaintion

Test added

@Kevin222004 Kevin222004 mentioned this pull request Oct 19, 2023
Closed
33 tasks
romani
romani approved these changes Oct 19, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge if ci pass

@romani romani requested a review from Vyom-Yadav October 19, 2023 21:44
@romani romani requested a review from rdiachenko October 19, 2023 21:44
Vyom-Yadav
Vyom-Yadav approved these changes Oct 20, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Vyom-Yadav Vyom-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Vyom-Yadav Vyom-Yadav assigned romani and unassigned Vyom-Yadav Oct 20, 2023
@romani romani assigned rdiachenko and unassigned romani Oct 20, 2023
@romani romani merged commit f43a897 into checkstyle:master Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko Awaiting requested review from rdiachenko

+1 more reviewer

@Vyom-Yadav Vyom-Yadav Vyom-Yadav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rdiachenko rdiachenko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kevin222004 @romani @Vyom-Yadav @rdiachenko