Skip to content

Issue #13809: kill mutation for JavadocPropertiesGenerator-2#13870

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:FinalCommon2
Oct 11, 2023
Merged

Issue #13809: kill mutation for JavadocPropertiesGenerator-2#13870
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:FinalCommon2

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Oct 11, 2023 •
edited
Loading

Issue #13809: kill mutation for JavadocPropertiesGenerator-2

Mutation

checkstyle/config/pitest-suppressions/pitest-common-2-suppressions.xml

Lines 13 to 20 in 649b669

<mutation unstable="false">
<sourceFile>JavadocPropertiesGenerator.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.JavadocPropertiesGenerator</mutatedClass>
<mutatedMethod>main</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
<description>replaced call to picocli/CommandLine::setUsageHelpWidth with receiver</description>
<lineContent>final CommandLine cmd = new CommandLine(cliOptions).setUsageHelpWidth(USAGE_HELP_WIDTH);</lineContent>
</mutation>

Explaintaion

we don't need help when we run cmd from the config

@Kevin222004 Kevin222004 mentioned this pull request Oct 11, 2023
Closed
33 tasks
romani
romani approved these changes Oct 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we do not need help rendering beautification for internal execution as execution not done by humans.

It was done during migration as sweeping update for all CLI like execution.

@romani romani merged commit 1c6e4b7 into checkstyle:master Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kevin222004 @romani