Skip to content

Issue #13809: kill mutation for AuditEventDefaultFormatter#13826

Merged
rdiachenko merged 1 commit intocheckstyle:masterfrom
Kevin222004:AuditEventDefaultFormatter
Oct 7, 2023
Merged

Issue #13809: kill mutation for AuditEventDefaultFormatter#13826
rdiachenko merged 1 commit intocheckstyle:masterfrom
Kevin222004:AuditEventDefaultFormatter

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

Issue #13809: kill mutation for AuditEventDefaultFormatter

Explaintation

I didn't find any test case for this and the reason may be in StringBuilder even after we assign the capacity if the character or string goes beyond the limit of assigned capacity. it will automatically expands the necessary memory to accommodate character to string builder.

@Kevin222004 Kevin222004 force-pushed the AuditEventDefaultFormatter branch from 4c21095 to 1da8d2b Compare October 4, 2023 09:38
@Kevin222004 Kevin222004 force-pushed the AuditEventDefaultFormatter branch 3 times, most recently from fbaeca3 to 02690a6 Compare October 4, 2023 11:13
@romani
Copy link
Copy Markdown
Member

romani commented Oct 4, 2023

Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

@romani romani self-assigned this Oct 4, 2023
@Kevin222004 Kevin222004 force-pushed the AuditEventDefaultFormatter branch 2 times, most recently from b24014d to 0566523 Compare October 4, 2023 16:09
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

@Kevin222004 Kevin222004 force-pushed the AuditEventDefaultFormatter branch 3 times, most recently from 777aa81 to cc246f9 Compare October 5, 2023 09:20
@romani
Copy link
Copy Markdown
Member

romani commented Oct 5, 2023

@Kevin222004 , please move forward to other mutation s, I will handle this update to figure out how to avoid mutation.

@romani romani force-pushed the AuditEventDefaultFormatter branch from cc246f9 to 8adf5ae Compare October 7, 2023 15:23
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge.

I did this change :).

@romani romani requested a review from rdiachenko October 7, 2023 15:24
@romani romani assigned rdiachenko and unassigned romani Oct 7, 2023
@romani romani force-pushed the AuditEventDefaultFormatter branch from 8adf5ae to b4cbba4 Compare October 7, 2023 15:25
@Kevin222004 Kevin222004 force-pushed the AuditEventDefaultFormatter branch from b4cbba4 to 04c940e Compare October 7, 2023 16:25
@Kevin222004
Copy link
Copy Markdown
Contributor Author

@romani thanks, I have Fixed the ci

Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko rdiachenko merged commit 7d53438 into checkstyle:master Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants