Issue #13809: kill mutation for JavadocPropertiesGenerator by Kevin222004 · Pull Request #13821 · checkstyle/checkstyle

Kevin222004 · 2023-10-04T05:05:20Z

Issue #13809: kill mutation for JavadocPropertiesGenerator

Mutation

checkstyle/config/pitest-suppressions/pitest-common-2-suppressions.xml

Lines 111 to 118 in a7fa83a

    
           <mutation unstable="false"> 
        
             <sourceFile>JavadocPropertiesGenerator.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.JavadocPropertiesGenerator</mutatedClass> 
        
             <mutatedMethod>getFirstJavadocSentence</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to com/puppycrawl/tools/checkstyle/api/DetailAST::getNextSibling</description> 
        
             <lineContent>child = child.getNextSibling()) {</lineContent> 
        
           </mutation>

Explaintaion

Test

romani · 2023-10-04T05:21:22Z

This is internal class to generate one txt file.
If content of file is same, just apply mutation to make pitest happy.

We do not need to test this class much, it doesn't execute on unpredictable user code.

Kevin222004 · 2023-10-04T08:48:16Z

As per the exisiting test if we follow the mutation then it must be timeout but the mutation is surviving.

romani · 2023-10-10T04:35:06Z

Tests are failing https://app.travis-ci.com/github/checkstyle/checkstyle/builds/266475895#L1555

romani · 2023-10-10T12:52:58Z

this class is executed at

checkstyle/pom.xml

Lines 781 to 797 in d74f431

    
           <artifactId>exec-maven-plugin</artifactId> 
        
           <executions> 
        
             <execution> 
        
               <phase>process-classes</phase> 
        
               <goals> 
        
                 <goal>java</goal> 
        
               </goals> 
        
               <configuration> 
        
                 <classpathScope>compile</classpathScope> 
        
                 <mainClass>com.puppycrawl.tools.checkstyle.JavadocPropertiesGenerator</mainClass> 
        
                 <arguments> 
        
                   <argument> 
        
                     ${project.build.sourceDirectory}/com/puppycrawl/tools/checkstyle/api/TokenTypes.java 
        
                   </argument> 
        
                   <argument>--destfile</argument> 
        
                   <argument> 
        
                     ${project.build.outputDirectory}/com/puppycrawl/tools/checkstyle/api/tokentypes.properties

result file tokentypes.properties is not in git, so please show CLI prove that content of it is not changed.

romani

Items:

...awl/tools/checkstyle/javadocpropertiesgenerator/InputJavadocPropertiesGeneratorCorrect2.java

romani

Items

src/test/java/com/puppycrawl/tools/checkstyle/JavadocPropertiesGeneratorTest.java

...awl/tools/checkstyle/javadocpropertiesgenerator/InputJavadocPropertiesGeneratorCorrect2.java

romani

Ok to merge

romani

CI must be green

romani

Ok to merge

Kevin222004 mentioned this pull request Oct 4, 2023

Resolve pitest survivals in modules - 5 #13809

Closed

33 tasks

Kevin222004 force-pushed the Common2 branch from ca61512 to bc1f03d Compare October 10, 2023 04:19

Kevin222004 marked this pull request as ready for review October 10, 2023 04:19

Kevin222004 force-pushed the Common2 branch from bc1f03d to 80a9b31 Compare October 10, 2023 16:38

romani requested changes Oct 11, 2023

View reviewed changes

...awl/tools/checkstyle/javadocpropertiesgenerator/InputJavadocPropertiesGeneratorCorrect2.java Outdated Show resolved Hide resolved

...awl/tools/checkstyle/javadocpropertiesgenerator/InputJavadocPropertiesGeneratorCorrect2.java Outdated Show resolved Hide resolved

Kevin222004 force-pushed the Common2 branch 2 times, most recently from def3e80 to 44a57e5 Compare October 11, 2023 04:19

romani requested changes Oct 11, 2023

View reviewed changes

src/test/java/com/puppycrawl/tools/checkstyle/JavadocPropertiesGeneratorTest.java Outdated Show resolved Hide resolved

...awl/tools/checkstyle/javadocpropertiesgenerator/InputJavadocPropertiesGeneratorCorrect2.java Outdated Show resolved Hide resolved

Kevin222004 force-pushed the Common2 branch from 44a57e5 to fd85dcc Compare October 11, 2023 04:45

romani approved these changes Oct 11, 2023

View reviewed changes

romani requested changes Oct 11, 2023

View reviewed changes

Issue checkstyle#13809: kill mutation for JavadocPropertiesGenerator

19c69ef

Kevin222004 force-pushed the Common2 branch from fd85dcc to 19c69ef Compare October 11, 2023 05:26

romani approved these changes Oct 11, 2023

View reviewed changes

romani merged commit 4ce6328 into checkstyle:master Oct 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Issue #13809: kill mutation for JavadocPropertiesGenerator#13821

Issue #13809: kill mutation for JavadocPropertiesGenerator#13821
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:Common2

Kevin222004 commented Oct 4, 2023 •

edited

Loading

Uh oh!

romani commented Oct 4, 2023

Uh oh!

Kevin222004 commented Oct 4, 2023

Uh oh!

romani commented Oct 10, 2023

Uh oh!

romani commented Oct 10, 2023 •

edited

Loading

Uh oh!

romani left a comment

Uh oh!

Uh oh!

Uh oh!

romani left a comment

Uh oh!

Uh oh!

Uh oh!

romani left a comment

Uh oh!

romani left a comment

Uh oh!

romani left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	<mutation unstable="false">
	<sourceFile>JavadocPropertiesGenerator.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.JavadocPropertiesGenerator</mutatedClass>
	<mutatedMethod>getFirstJavadocSentence</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
	<description>removed call to com/puppycrawl/tools/checkstyle/api/DetailAST::getNextSibling</description>
	<lineContent>child = child.getNextSibling()) {</lineContent>
	</mutation>

Uh oh!

Conversation

Kevin222004 commented Oct 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mutation

Explaintaion

Uh oh!

romani commented Oct 4, 2023

Uh oh!

Kevin222004 commented Oct 4, 2023

Uh oh!

romani commented Oct 10, 2023

Uh oh!

romani commented Oct 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Kevin222004 commented Oct 4, 2023 •

edited

Loading

romani commented Oct 10, 2023 •

edited

Loading