Skip to content

Issue #13809: kill mutation for AbstarctRootNode#13818

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:XpathAttribute
Oct 5, 2023
Merged

Issue #13809: kill mutation for AbstarctRootNode#13818
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:XpathAttribute

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Oct 3, 2023 •
edited by romani
Loading

Issue #13809: kill mutation for AbstarctRootNode

Mutation

checkstyle/config/pitest-suppressions/pitest-xpath-suppressions.xml

Lines 3 to 10 in d316b89

<mutation unstable="true">
<sourceFile>AbstractRootNode.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.xpath.AbstractRootNode</mutatedClass>
<mutatedMethod>iterateAxis</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.RemoveSwitchMutator_2</mutator>
<description>RemoveSwitch 2 (case value 2)</description>
<lineContent>switch (axisNumber) {</lineContent>
</mutation>

Attributes are not allowed by design:

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/xpath/AbstractRootNode.java

Lines 73 to 75 in a7fa83a

public String getAttributeValue(NamespaceUri namespace, String localPart) {
throw throwUnsupportedOperationException();
}

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Oct 3, 2023

I am not finding any query in which attribute axis is used as a root just like I created a test for an ancestor-or-self axis
#13771.

@Kevin222004 Kevin222004 mentioned this pull request Oct 3, 2023
Closed
33 tasks
romani
romani approved these changes Oct 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No attributes on root.
Root is

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/utils/TokenUtil.java

Lines 315 to 317 in a7fa83a

public static boolean isRootNode(DetailAST ast) {
return ast.getType() == TokenTypes.COMPILATION_UNIT;
}

@romani romani requested a review from rdiachenko October 4, 2023 04:33
rdiachenko
rdiachenko approved these changes Oct 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko
Copy link
Copy Markdown
Member

rdiachenko commented Oct 4, 2023

rebased

@rdiachenko rdiachenko assigned romani and unassigned rdiachenko Oct 4, 2023
@romani romani requested a review from Vyom-Yadav October 4, 2023 23:36
@romani romani assigned Vyom-Yadav and unassigned romani Oct 4, 2023
@romani
Copy link
Copy Markdown
Member

romani commented Oct 5, 2023

@Kevin222004 , please resolve conflict

@romani romani merged commit bc281c4 into checkstyle:master Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

@Vyom-Yadav Vyom-Yadav Awaiting requested review from Vyom-Yadav

Assignees

@Vyom-Yadav Vyom-Yadav

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kevin222004 @rdiachenko @romani @Vyom-Yadav