Skip to content

Issue #13809: kill mutation for RootNode getColumnNumber#13817

Merged
romani merged 1 commit intocheckstyle:masterfrom
romani:i13809-root-col
Oct 5, 2023
Merged

Issue #13809: kill mutation for RootNode getColumnNumber#13817
romani merged 1 commit intocheckstyle:masterfrom
romani:i13809-root-col

Conversation

@romani
Copy link
Copy Markdown
Member

@romani romani commented Oct 3, 2023

Issue #13809

@romani
Copy link
Copy Markdown
Member Author

romani commented Oct 3, 2023

@rnveach , do you remmber why lines starts with 1 but columns from 0 ?
Looks weird.

@rnveach
Copy link
Copy Markdown
Contributor

rnveach commented Oct 3, 2023

#4997
#5877

@romani romani force-pushed the i13809-root-col branch 2 times, most recently from 815c4ef to e530bbd Compare October 4, 2023 12:49
@romani
Copy link
Copy Markdown
Member Author

romani commented Oct 4, 2023

@rnveach , I put link to issue as "until" for this pure unit test.

Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@romani
Copy link
Copy Markdown
Member Author

romani commented Oct 5, 2023

Vyom allowed to merge without him until Monday

@romani romani merged commit 81f6431 into checkstyle:master Oct 5, 2023
@romani romani deleted the i13809-root-col branch October 5, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants