Skip to content

Issue #13809: Kill mutation in pitest-api profile#13810

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:violation
Oct 1, 2023
Merged

Issue #13809: Kill mutation in pitest-api profile#13810
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:violation

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Oct 1, 2023

Issue #13809: Kill mutation in pitest-api profile

Just test added.

Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

item:

import nl.jqno.equalsverifier.EqualsVerifierReport;

public class ViolationTest {
public class ViolationTest extends AbstractModuleTestSupport {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Violation class is not a module.

can you move test to InterfaceMemberImpliedModifierCheckTest?
and just execution InterfaceMemberImpliedModifierCheckTest in api group of pitest.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case was just found by just hit and trial by run all the check in local for API group and generating pit report.

I have include this test so that for a single test we can avoid all test execution.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this.
I hope one day we will find a way to run single test by pitest config.
This is good feeback point to pitest project.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it to #13142


package com.puppycrawl.tools.checkstyle.api.violation;

public interface InputViolation1 {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name it InputTwoViolationOnSameLine

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romani romani self-assigned this Oct 1, 2023
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants