Issue #13672: kill pitest mutation in XmlLoader#13804
Merged
romani merged 1 commit intocheckstyle:masterfrom Oct 5, 2023
Merged
Issue #13672: kill pitest mutation in XmlLoader#13804romani merged 1 commit intocheckstyle:masterfrom
romani merged 1 commit intocheckstyle:masterfrom
Conversation
29 tasks
8e2b5a1 to
d59744b
Compare
3998a7e to
13300b5
Compare
13300b5 to
1207d66
Compare
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
one item from Issue #13672
test is not for coverage of mutation, just to prove that SYSTEM reference works.
There is no plans for jdk to remove:
https://github.com/openjdk/jdk17/blob/4afbcaf55383ec2f5da53282a1547bac3d099e9d/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java#L1059-L1067
https://github.com/openjdk/jdk/blob/bd918f49d29bcbc699e07b4ef8d23cfe1abd32df/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java#L1062-L1070
so it handle null from this method as required and do load of system entity already, so we do not need to do this in our code. So now code just handle load by PUBLIC and something is not matching/found return null, and Xerces does load by SYSTEM.
JavaParser.java mutation is just moved up, I was not able to keep it at original place, as after each execution of our pitest scrip it is moved up.