Skip to content

Issue #13672: Kill mutation for Filter#13788

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:Filter1
Sep 27, 2023
Merged

Issue #13672: Kill mutation for Filter#13788
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:Filter1

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Sep 26, 2023 •
edited
Loading

Issue #13672: Kill mutation for Filter

Filter

SuppressionFIlter :- https://checkstyle.sourceforge.io/filters/suppressionfilter.html#SuppressionFilter

SuppressionXpathFilter :- https://checkstyle.sourceforge.io/filters/suppressionxpathfilter.html#SuppressionXpathFilter

Mutation

checkstyle/config/pitest-suppressions/pitest-filters-suppressions.xml

Lines 309 to 316 in d73d905

<mutation unstable="false">
<sourceFile>SuppressionFilter.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.filters.SuppressionFilter</mutatedClass>
<mutatedMethod>finishLocalSetup</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
<description>Removed assignment to member variable filters</description>
<lineContent>filters = SuppressionsLoader.loadSuppressions(file);</lineContent>
</mutation>

and

checkstyle/config/pitest-suppressions/pitest-filters-suppressions.xml

Lines 327 to 343 in d73d905

<mutation unstable="false">
<sourceFile>SuppressionFilter.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.filters.SuppressionFilter</mutatedClass>
<mutatedMethod>getExternalResourceLocations</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.returns.EmptyObjectReturnValsMutator</mutator>
<description>replaced return value with Collections.emptySet for com/puppycrawl/tools/checkstyle/filters/SuppressionFilter::getExternalResourceLocations</description>
<lineContent>return Collections.singleton(file);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>SuppressionXpathFilter.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.filters.SuppressionXpathFilter</mutatedClass>
<mutatedMethod>finishLocalSetup</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/util/Set::addAll</description>
<lineContent>filters.addAll(SuppressionsLoader.loadXpathSuppressions(file));</lineContent>
</mutation>

Explaination

Test and Expanition of util method

@romani
Copy link
Copy Markdown
Member

romani commented Sep 26, 2023

Inspections are not happy
https://app.circleci.com/pipelines/github/checkstyle/checkstyle/20995/workflows/bbc06313-40fc-4b7e-8ad0-7390b4668eb0/jobs/392686/artifacts

@Kevin222004 Kevin222004 mentioned this pull request Sep 26, 2023
Closed
29 tasks
romani
romani approved these changes Sep 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge, change in main code is typical workaround to avoid pitest on data copy for data protection

@romani romani merged commit dcadaa1 into checkstyle:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kevin222004 @romani