Issue #13672: Kill mutation for Xpath#13768
Merged
romani merged 1 commit intocheckstyle:masterfrom Sep 24, 2023
Merged
Conversation
Kevin222004
commented
Sep 23, 2023
| <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.RemoveSwitchMutator_8</mutator> | ||
| <description>RemoveSwitch 8 (case value 8)</description> | ||
| <lineContent>switch (axisNumber) {</lineContent> | ||
| </mutation> |
Contributor
Author
There was a problem hiding this comment.
Their is no case in which the case value 8 is used
d448fd0 to
fa12594
Compare
romani
requested changes
Sep 24, 2023
Comment on lines
+2
to
+15
| com.puppycrawl.tools.checkstyle.filters.SuppressionXpathFilter | ||
| file = (file)InputAbstractRootNode.xml | ||
| optional = (default)false | ||
|
|
||
| com.puppycrawl.tools.checkstyle.checks.coding.IllegalTokenTextCheck | ||
| format = [^a-zA-z0-9]* | ||
| ignoreCase = (default)false | ||
| message = (default) | ||
| tokens = CHAR_LITERAL | ||
|
|
||
| */ | ||
| package com.puppycrawl.tools.checkstyle.xpath.abstractrootnode; | ||
|
|
||
| public class InputAbstractRootNode { |
Member
There was a problem hiding this comment.
SuppressionXpathFilter vs InputAbstractRootNode is red flag.
please move this code to SuppressionXpathFilterTest.
fact that we have some abstract class does not mean that we need to test is as abstract. We test all from user perspective, user knows only SuppressionXpathFilter and amount of abstract classes or classes used by composite that are under it does not matter.
if you keep all tests at level of SuppressionXpathFilter we can refactor all easily and we will never need to change a test.
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #13672: Kill mutation for Xpath
Mutation
checkstyle/config/pitest-suppressions/pitest-xpath-suppressions.xml
Lines 30 to 46 in c525c67
and
checkstyle/config/pitest-suppressions/pitest-xpath-suppressions.xml
Lines 3 to 10 in c525c67
Explaination
Test added