Skip to content

Issue #13672: Kill mutation in TreeWalker-1#13684

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:TreeWalker
Sep 2, 2023
Merged

Issue #13672: Kill mutation in TreeWalker-1#13684
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:TreeWalker

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Sep 2, 2023 •
edited
Loading

Issue #13672: Kill mutation in TreeWalker-1

Mutation

checkstyle/config/pitest-suppressions/pitest-tree-walker-suppressions.xml

Lines 111 to 136 in ca7d6d6

<mutation unstable="false">
<sourceFile>TreeWalker.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.TreeWalker</mutatedClass>
<mutatedMethod>registerCheck</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/lang/Class::getName</description>
<lineContent>+ &quot;method to return &apos;true&apos;&quot;, check.getClass().getName(),</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>TreeWalker.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.TreeWalker</mutatedClass>
<mutatedMethod>registerCheck</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to com/puppycrawl/tools/checkstyle/utils/TokenUtil::getTokenName</description>
<lineContent>TokenUtil.getTokenName(tokenId));</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>TreeWalker.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.TreeWalker</mutatedClass>
<mutatedMethod>registerCheck</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
<description>replaced call to java/lang/String::format with argument</description>
<lineContent>final String message = String.format(Locale.ROOT, &quot;Check &apos;%s&apos; waits for comment type &quot;</lineContent>
</mutation>

Explaintion

Test update

@Kevin222004 Kevin222004 mentioned this pull request Sep 2, 2023
Closed
29 tasks
romani
romani approved these changes Sep 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge.

exceptional cases we are ok to test by non-Input

@romani romani merged commit 08814f2 into checkstyle:master Sep 2, 2023
@Vyom-Yadav Vyom-Yadav mentioned this pull request Sep 11, 2023
Merged
@Kevin222004 Kevin222004 mentioned this pull request Oct 1, 2023
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kevin222004 @romani