Skip to content

Issue #13666: Assert that properties are ordered alphabetically in xdoc#13667

Merged
romani merged 1 commit into
checkstyle:masterfrom
stoyanK7:13666
Aug 30, 2023
Merged

Issue #13666: Assert that properties are ordered alphabetically in xdoc#13667
romani merged 1 commit into
checkstyle:masterfrom
stoyanK7:13666

Conversation

@stoyanK7

@stoyanK7 stoyanK7 commented Aug 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Resolves #13666

  • Adds extra check in XdocsPagesTest to assert that the properties are ordered alphabetically with javadocTokens and tokens being last
  • Adds a suppression list of all modules whose properties are not ordered
  • Orders the properties of AnnotationUseStyle

@stoyanK7

stoyanK7 commented Aug 30, 2023

Copy link
Copy Markdown
Collaborator Author

Example failure:
https://dev.azure.com/romanivanovjr/romanivanovjr/_build/results?buildId=16276&view=logs&j=eb841e9f-6e1e-5c29-3ad5-74ec2c658069&t=a9b761e6-b8d5-50cf-467a-54967189cab2&l=1318

[ERROR] Failures: 
[ERROR]   XdocsPagesTest.testAllCheckSections:648->validateCheckSection:731->validatePropertySection:873->validatePropertySectionPropertiesOrder:920 annotationusestyle.xml section 'AnnotationUseStyle' should have properties in the requested order
contents match, but order was wrong
expected: [closingParens, elementStyle, trailingArrayComma]
but was : [elementStyle, closingParens, trailingArrayComma]

This was referenced Aug 30, 2023
Merged
Closed
romani
romani approved these changes Aug 30, 2023
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge.

Merging sooner to unblock others PR.
Review can continue to fix in items in separate PRs.

@romani romani merged commit babe109 into checkstyle:master Aug 30, 2023
@stoyanK7 stoyanK7 deleted the 13666 branch August 30, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assert that properties are ordered alphabetically in xdoc

2 participants

@stoyanK7 @romani