Issue #13501: Kill mutation for JavaParser2#13658
Merged
romani merged 1 commit intocheckstyle:masterfrom Aug 30, 2023
Merged
Conversation
romani
approved these changes
Aug 29, 2023
Member
romani
left a comment
There was a problem hiding this comment.
Creation by File is more exact, that by absolute pass of it.
7b69a57 to
334adb8
Compare
Member
|
rebased |
61 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #13501: Kill mutation for JavaParser2
https://github.com/Kevin222004/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/JavaParser.java
Mutations
checkstyle/config/pitest-suppressions/pitest-common-2-suppressions.xml
Lines 102 to 109 in 7007bef
Explaination
https://github.com/Kevin222004/checkstyle/blob/7007bef1f43a621757ae0b885818cf8baa0e6ef1/src/main/java/com/puppycrawl/tools/checkstyle/JavaParser.java#L140
The code is mutated as to remove
file.getAbsoluteFile()-->filegetAbsoluteFile this method will give the absolute path of file.As per my research, the file from the parameter is already an absolute file path. I also don't think that test case is even possible because if we provide only filename then it will become exception.
Regression