Issue #13501: Kill mutation for DetailAstImpl-4 by Kevin222004 · Pull Request #13649 · checkstyle/checkstyle

Kevin222004 · 2023-08-27T09:17:27Z

Issue #13501: Kill mutation for DetailAstImpl-4

https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/DetailAstImpl.java

Mutations

checkstyle/config/pitest-suppressions/pitest-common-2-suppressions.xml

Lines 12 to 28 in 88486f7

    
           <mutation unstable="false"> 
        
             <sourceFile>DetailAstImpl.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.DetailAstImpl</mutatedClass> 
        
             <mutatedMethod>addChild</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to com/puppycrawl/tools/checkstyle/DetailAstImpl::getLastChild</description> 
        
             <lineContent>astImpl.previousSibling = (DetailAstImpl) getLastChild();</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>DetailAstImpl.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.DetailAstImpl</mutatedClass> 
        
             <mutatedMethod>addChild</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator> 
        
             <description>Removed assignment to member variable previousSibling</description> 
        
             <lineContent>astImpl.previousSibling = (DetailAstImpl) getLastChild();</lineContent> 
        
           </mutation>

Explaination

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/DetailAstImpl.java

Line 169 in 0dba32b

astImpl.previousSibling = (DetailAstImpl) getLastChild();

This line is mutated.

The similar reason #13391 and #13390 (comment)

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/DetailAstImpl.java

Line 180 in 0dba32b

((DetailAstImpl) temp).setNextSibling(child);

here the next sibiling will be set

Regression

No DIff

Report-1 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-17-02-02/part3-report/index.html

Report-2 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-17-02-02/sevntu-check-regression_part_1-report/index.html

Report-3 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-17-02-02/checks-nonjavadoc-error-report/index.html

Report-4 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-17-02-02/sevntu-check-regression_part_2-report/index.html

Report-5 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-17-02-02/checks-only-javadoc-error-report/index.html

Report-6 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-17-02-02/part1-report/index.html

Report-7 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-17-02-02/part5-report/index.html

Report-8 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-17-02-02/part6-report/index.html

Report-9 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-17-02-02/part4-report/index.html

Report-10 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-17-02-02/antlr-report/index.html

Report-11 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-17-02-02/part2-report/index.html

Report-12 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-21-10-43/part3-report/index.html

Report-13 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-21-10-43/sevntu-check-regression_part_1-report/index.html

Report-14 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-21-10-43/checks-nonjavadoc-error-report/index.html

Report-15 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-21-10-43/sevntu-check-regression_part_2-report/index.html

Report-16 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-21-10-43/checks-only-javadoc-error-report/index.html

Report-17 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-21-10-43/part1-report/index.html

Report-18 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-21-10-43/part5-report/index.html

Report-19 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-21-10-43/part6-report/index.html

Report-20 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-21-10-43/part4-report/index.html

Report-21 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-21-10-43/antlr-report/index.html

Report-22 :- https://kevin222004.github.io/reports/DetailAstImpl/2023-08-27-T-21-10-43/part2-report/index.html

romani

Ok to merge

rdiachenko · 2023-08-29T18:59:18Z

src/test/java/com/puppycrawl/tools/checkstyle/DetailAstImplTest.java

+        secondChild.setText("SecondChild");
+        parent.addChild(secondChild);
+
+        assertWithMessage("")


Please put a proper message, check other tests to get an idea.

src/main/java/com/puppycrawl/tools/checkstyle/DetailAstImpl.java

rdiachenko

lgtm

Vyom-Yadav

LGTM!

Kevin222004 changed the title ~~Issue #13501: Kill mutation for DetailAstImpl-3~~ Issue #13501: Kill mutation for DetailAstImpl-4 Aug 27, 2023

Kevin222004 force-pushed the DetailAstImpl branch from 8431356 to 7e83e5f Compare August 27, 2023 09:45

Kevin222004 marked this pull request as ready for review August 27, 2023 09:47

romani approved these changes Aug 29, 2023

View reviewed changes

romani requested a review from rdiachenko August 29, 2023 05:04

romani assigned rdiachenko Aug 29, 2023

rdiachenko reviewed Aug 29, 2023

View reviewed changes

rdiachenko added the awaiting response label Aug 31, 2023

Issue checkstyle#13501: Kill mutation for DetailAstImpl-4

ae1d2ed

Kevin222004 force-pushed the DetailAstImpl branch from 7e83e5f to ae1d2ed Compare September 1, 2023 18:11

rdiachenko removed the awaiting response label Sep 2, 2023

rdiachenko approved these changes Sep 2, 2023

View reviewed changes

rdiachenko assigned Vyom-Yadav and unassigned rdiachenko Sep 2, 2023

romani requested a review from Vyom-Yadav September 2, 2023 19:15

Kevin222004 mentioned this pull request Sep 3, 2023

Resolve pitest survivals in modules - 4 #13672

Closed

29 tasks

Vyom-Yadav approved these changes Sep 5, 2023

View reviewed changes

Vyom-Yadav assigned romani and unassigned Vyom-Yadav Sep 5, 2023

Vyom-Yadav mentioned this pull request Sep 5, 2023

Issue #13672: Kill mutation for DetailAstImpl-3 #13391

Merged

romani merged commit dbcbd67 into checkstyle:master Sep 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Issue #13501: Kill mutation for DetailAstImpl-4#13649

Issue #13501: Kill mutation for DetailAstImpl-4#13649
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:DetailAstImpl

Kevin222004 commented Aug 27, 2023 •

edited

Loading

Uh oh!

romani left a comment

Uh oh!

rdiachenko Aug 29, 2023

Uh oh!

Kevin222004 Sep 1, 2023

Uh oh!

Uh oh!

rdiachenko left a comment

Uh oh!

Vyom-Yadav left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	<mutation unstable="false">
	<sourceFile>DetailAstImpl.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.DetailAstImpl</mutatedClass>
	<mutatedMethod>addChild</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
	<description>removed call to com/puppycrawl/tools/checkstyle/DetailAstImpl::getLastChild</description>
	<lineContent>astImpl.previousSibling = (DetailAstImpl) getLastChild();</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>DetailAstImpl.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.DetailAstImpl</mutatedClass>
	<mutatedMethod>addChild</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
	<description>Removed assignment to member variable previousSibling</description>
	<lineContent>astImpl.previousSibling = (DetailAstImpl) getLastChild();</lineContent>
	</mutation>

Uh oh!

Conversation

Kevin222004 commented Aug 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mutations

Explaination

Regression

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

rdiachenko Aug 29, 2023

Choose a reason for hiding this comment

Uh oh!

Kevin222004 Sep 1, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rdiachenko left a comment

Choose a reason for hiding this comment

Uh oh!

Vyom-Yadav left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kevin222004 commented Aug 27, 2023 •

edited

Loading