Skip to content

Issue #13501: Kill mutation for CommonUtil #13648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romani merged 1 commit into from
Aug 28, 2023
Merged

Issue #13501: Kill mutation for CommonUtil #13648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions config/pitest-suppressions/pitest-utils-suppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,14 +225,14 @@
<lineContent>return stripLeading(strippedCodePoints);</lineContent>
</mutation>

<mutation unstable="false">
<sourceFile>CommonUtil.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.utils.CommonUtil</mutatedClass>
<mutatedMethod>baseClassName</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator>
<description>removed conditional - replaced equality check with false</description>
<lineContent>if (index == -1) {</lineContent>
</mutation>











Expand Down
9 changes: 1 addition & 8 deletions src/main/java/com/puppycrawl/tools/checkstyle/utils/CommonUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,15 +241,8 @@ public static boolean isPatternValid(String pattern) {
* @return the base class name from a fully qualified name
*/
public static String baseClassName(String type) {
final String className;
final int index = type.lastIndexOf('.');
if (index == -1) {
className = type;
}
else {
className = type.substring(index + 1);
}
return className;
return type.substring(index + 1);
}

/**
Expand Down