Skip to content

Issue #13213: Remove '//ok' comments from Input files (MethodParamPad… #13609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rnveach merged 1 commit into from
Sep 9, 2023
Merged

Issue #13213: Remove '//ok' comments from Input files (MethodParamPad… #13609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions config/checkstyle-input-suppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6317,12 +6317,6 @@
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]packageinfo[\\/]test1[\\/]package-info.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]whitespace[\\/]emptylineseparator[\\/]packageinfo[\\/]test2[\\/]package-info.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]whitespace[\\/]methodparampad[\\/]InputMethodParamPad4.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]whitespace[\\/]methodparampad[\\/]InputMethodParamPadSetOptionTrim.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]whitespace[\\/]methodparampad[\\/]InputMethodParamPadWhitespaceAround.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]whitespace[\\/]nolinewrap[\\/]InputNoLineWrapGood.java"/>
<suppress id="UnnecessaryOkComment"
Expand Down
2 changes: 1 addition & 1 deletion ...om/puppycrawl/tools/checkstyle/checks/whitespace/methodparampad/InputMethodParamPad4.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
package com.puppycrawl.tools.checkstyle.checks.whitespace.methodparampad;
import java.util.Vector;
/** Test input for MethodDefPadCheck */
public class InputMethodParamPad4 // ok
public class InputMethodParamPad4
{
public InputMethodParamPad4()
{
Expand Down
2 changes: 1 addition & 1 deletion ...l/tools/checkstyle/checks/whitespace/methodparampad/InputMethodParamPadSetOptionTrim.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public void method1() { // violation ''(' is not preceded with whitespace'
}
}

public int method2 () { // ok
public int method2 () {
return 1;
}

Expand Down
14 changes: 11 additions & 3 deletions ...ools/checkstyle/checks/whitespace/methodparampad/InputMethodParamPadWhitespaceAround.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,24 @@
package com.puppycrawl.tools.checkstyle.checks.whitespace.methodparampad;

@SuppressWarnings({"this", "that"})
public class InputMethodParamPadWhitespaceAround // ok
public class InputMethodParamPadWhitespaceAround
{
protected InputMethodParamPadWhitespaceAround ( int i )
{
this (); //whitespace
this (); // ok, whitespace between 'this' and ()
toString ();
}
protected InputMethodParamPadWhitespaceAround ()
{
super ();
}

protected InputMethodParamPadWhitespaceAround ( String s)
{
// ok, until https://github.com/checkstyle/checkstyle/issues/13675
this();
}

public void enhancedFor ()
{
int[] i = new int[2];
Expand All @@ -33,9 +39,11 @@ public void enhancedFor ()
}

@interface CronExpression {
// annotation type elements are not checked
Class<?>[] groups() default {};
}

@interface CronExpression1 {
Class<?>[] groups() default { }; // extra space
// annotation type elements are not checked
Class<?>[] groups() default { };
}