Skip to content

Issue #13501: Kill mutation for AbstarctJavadoc#13602

Closed
Kevin222004 wants to merge 2 commits into
checkstyle:masterfrom
Kevin222004:AbstractJavadocCheck1
Closed

Issue #13501: Kill mutation for AbstarctJavadoc#13602
Kevin222004 wants to merge 2 commits into
checkstyle:masterfrom
Kevin222004:AbstractJavadocCheck1

Conversation

@Kevin222004

@Kevin222004 Kevin222004 commented Aug 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue #13501: Kill mutation for AbstarctJavadoc

Check

https://checkstyle.org/checks/javadoc/javadocparagraph.html#JavadocParagraph

Mutation

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 48 to 55 in 94cd165

<mutation unstable="false">
<sourceFile>AbstractJavadocCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractJavadocCheck</mutatedClass>
<mutatedMethod>walk</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator>
<description>removed conditional - replaced equality check with true</description>
<lineContent>if (toVisit == null) {</lineContent>
</mutation>

Explaination

Regression :-

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/10d05d95e2866971a35d42cdb6935896/raw/ab95558b4483d0070191e6dbf6dfec769104e3f3/JavadocTagInfo.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: Regression-1

@Kevin222004

Kevin222004 commented Aug 23, 2023

Copy link
Copy Markdown
Contributor Author

Github, generate report

@Kevin222004 Kevin222004 changed the title Issue #13501: Kill mutation for JavadocTagInfo Issue checkstyle#13501: Kill mutation for AbstarctJavadoc Aug 23, 2023
@Kevin222004 Kevin222004 changed the title Issue checkstyle#13501: Kill mutation for AbstarctJavadoc Issue #13501: Kill mutation for AbstarctJavadoc Aug 25, 2023
@Kevin222004

Kevin222004 commented Sep 24, 2023

Copy link
Copy Markdown
Contributor Author

Github, generate report

@github-actions

github-actions Bot commented Sep 24, 2023

Copy link
Copy Markdown
Contributor

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/f574d23_2023191328/reports/diff/index.html

@romani

romani commented Sep 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@Kevin222004 , in config please use checks that extends this abstract class.
It for checks that are at based.

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocStyleCheck.java

Lines 179 to 180 in 50c6672

public class JavadocStyleCheck
extends AbstractCheck {

@Kevin222004

Kevin222004 commented Nov 11, 2023

Copy link
Copy Markdown
Contributor Author

Covering at #13999

@Kevin222004 Kevin222004 mentioned this pull request Nov 11, 2023
Closed
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kevin222004 @romani @Vyom-Yadav