Skip to content

Issue #13501: Kill mutation for JavadocParagraph2#13590

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:JavadocParagraph2
Aug 23, 2023
Merged

Issue #13501: Kill mutation for JavadocParagraph2#13590
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:JavadocParagraph2

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Aug 22, 2023

Issue #13501: Kill mutation for JavadocParagraph2


Check

https://checkstyle.org/checks/javadoc/javadocparagraph.html#JavadocParagraph


Mutation

<mutation unstable="false">
<sourceFile>JavadocParagraphCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocParagraphCheck</mutatedClass>
<mutatedMethod>isEmptyLine</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator>
<description>removed conditional - replaced equality check with true</description>
<lineContent>if (previousSibling.getType() == JavadocTokenTypes.TEXT</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>JavadocParagraphCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocParagraphCheck</mutatedClass>
<mutatedMethod>isFirstParagraph</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator>
<description>removed conditional - replaced equality check with false</description>
<lineContent>&amp;&amp; previousNode.getType() != JavadocTokenTypes.NEWLINE</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>JavadocParagraphCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocParagraphCheck</mutatedClass>
<mutatedMethod>isFirstParagraph</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator>
<description>removed conditional - replaced equality check with false</description>
<lineContent>&amp;&amp; previousNode.getType() != JavadocTokenTypes.TEXT) {</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>JavadocParagraphCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocParagraphCheck</mutatedClass>
<mutatedMethod>isFirstParagraph</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator>
<description>removed conditional - replaced equality check with false</description>
<lineContent>|| previousNode.getType() != JavadocTokenTypes.LEADING_ASTERISK</lineContent>
</mutation>


Explaination

Test added


Regression :-


Diff Regression config: https://gist.githubusercontent.com/Kevin222004/131e059942a4ef61d37aef621fe27777/raw/eb52f0fe0b9810e3fe6192ece69350da2ca40115/JavadocParagraph.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: Regression-2

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Github, generate report

1 similar comment
@Kevin222004
Copy link
Copy Markdown
Contributor Author

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 marked this pull request as ready for review August 23, 2023 05:17
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani merged commit a1db06b into checkstyle:master Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants