Skip to content

Issue #13501: Kill mutation for JavadocStyleCheck7#13581

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:JavadocStyleCheck7
Aug 23, 2023
Merged

Issue #13501: Kill mutation for JavadocStyleCheck7#13581
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:JavadocStyleCheck7

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Aug 21, 2023 •
edited
Loading

Issue #13501: Kill mutation for JavadocStyleCheck7

Check

https://checkstyle.org/checks/javadoc/javadocstyle.html#JavadocStyle

Mutation

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 420 to 451 in d2c985e

<mutatedMethod>trimTail</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/lang/StringBuilder::deleteCharAt</description>
<lineContent>builder.deleteCharAt(index - 1);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>JavadocStyleCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck</mutatedClass>
<mutatedMethod>trimTail</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
<description>replaced call to java/lang/StringBuilder::deleteCharAt with receiver</description>
<lineContent>builder.deleteCharAt(index - 1);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>JavadocStyleCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck</mutatedClass>
<mutatedMethod>trimTail</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/lang/StringBuilder::deleteCharAt</description>
<lineContent>builder.deleteCharAt(index);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>JavadocStyleCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck</mutatedClass>
<mutatedMethod>trimTail</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
<description>replaced call to java/lang/StringBuilder::deleteCharAt with receiver</description>
<lineContent>builder.deleteCharAt(index);</lineContent>
</mutation>

Explaination

Test added

Regression :-

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/0b07ecc7d3ca0ca403454d504707156d/raw/8c76ea8db01b4bcb565d1af9301130f7c67c3c1d/JavadocStyleCheck.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/21e3934e85f802e2fbd48af06d122364/raw/604256badd733d8568064f371d55657c04b00dfd/test-projects-2.properties
Report label: Regression-1

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Aug 22, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 22, 2023

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/6c980a8_2023060621/reports/diff/index.html

@Kevin222004 Kevin222004 marked this pull request as ready for review August 22, 2023 07:26
@romani
Copy link
Copy Markdown
Member

romani commented Aug 22, 2023

Please rebase to resolve pitest https://github.com/checkstyle/checkstyle/actions/runs/5935740639/job/16094748701?pr=13581

rdiachenko
rdiachenko approved these changes Aug 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kevin222004 Kevin222004 mentioned this pull request Aug 22, 2023
Closed
61 tasks
@romani romani merged commit 2e8e71c into checkstyle:master Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

Assignees

@romani romani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kevin222004 @romani @rdiachenko