Skip to content

Issue #13501: Kill mutation for JavadocStyleCheck6#13580

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:JavadocStyleCheck6
Aug 23, 2023
Merged

Issue #13501: Kill mutation for JavadocStyleCheck6#13580
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:JavadocStyleCheck6

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Aug 21, 2023 •
edited
Loading

Issue #13501: Kill mutation for JavadocStyleCheck6

Check

https://checkstyle.org/checks/javadoc/javadocstyle.html#JavadocStyle

Mutation

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 408 to 415 in d2c985e

<mutation unstable="false">
<sourceFile>JavadocStyleCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck</mutatedClass>
<mutatedMethod>trimTail</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator>
<description>removed conditional - replaced equality check with true</description>
<lineContent>&amp;&amp; builder.charAt(index - 1) == &apos;*&apos;) {</lineContent>
</mutation>

Explaination

Regression :-

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/0b07ecc7d3ca0ca403454d504707156d/raw/8c76ea8db01b4bcb565d1af9301130f7c67c3c1d/JavadocStyleCheck.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: Regression-2

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Aug 21, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 21, 2023

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/4b7d3ad_2023215826/reports/diff/index.html

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Aug 22, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 22, 2023

Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/4b7d3ad_2023052205/reports/diff/index.html

@Kevin222004 Kevin222004 marked this pull request as ready for review August 22, 2023 18:18
rdiachenko
rdiachenko approved these changes Aug 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kevin222004 Kevin222004 mentioned this pull request Aug 22, 2023
Closed
61 tasks
@romani romani merged commit a8cd125 into checkstyle:master Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

Assignees

@romani romani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kevin222004 @romani @rdiachenko