Skip to content

Issue #13501: Kill mutation for JavadocStyleCheck1#13575

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:JavadocStyleCheck1
Aug 21, 2023
Merged

Issue #13501: Kill mutation for JavadocStyleCheck1#13575
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:JavadocStyleCheck1

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Aug 21, 2023 •
edited
Loading

Issue #13501: Kill mutation for JavadocStyleCheck1

Check

https://checkstyle.org/checks/javadoc/javadocstyle.html#JavadocStyle

Mutation

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 390 to 406 in d2c985e

<mutation unstable="false">
<sourceFile>JavadocStyleCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck</mutatedClass>
<mutatedMethod>shouldCheck</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to com/puppycrawl/tools/checkstyle/api/DetailAST::getType</description>
<lineContent>if (ast.getType() == TokenTypes.PACKAGE_DEF) {</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>JavadocStyleCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck</mutatedClass>
<mutatedMethod>shouldCheck</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator>
<description>removed conditional - replaced equality check with false</description>
<lineContent>if (ast.getType() == TokenTypes.PACKAGE_DEF) {</lineContent>
</mutation>

Explaination

Test added

@Kevin222004 Kevin222004 changed the title Issue #13321: Kill mutation for JavadocStyleCheck1 Issue #13501: Kill mutation for JavadocStyleCheck1 Aug 21, 2023
romani
romani approved these changes Aug 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani merged commit fc8e0e4 into checkstyle:master Aug 21, 2023
@Kevin222004 Kevin222004 mentioned this pull request Aug 21, 2023
Closed
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kevin222004 @romani