Issue #13501: Kill mutation for JavadocTagContinuationIndentationCheck2 by Kevin222004 · Pull Request #13573 · checkstyle/checkstyle

Kevin222004 · 2023-08-20T19:50:54Z

Issue #13501: Kill mutation for JavadocTagContinuationIndentationCheck2

Check

https://checkstyle.org/checks/javadoc/javadoctagcontinuationindentation.html#JavadocTagContinuationIndentation

Mutation

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 516 to 541 in d2c985e

    
           <mutation unstable="false"> 
        
             <sourceFile>JavadocTagContinuationIndentationCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagContinuationIndentationCheck</mutatedClass> 
        
             <mutatedMethod>isInlineDescription</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator> 
        
             <description>replaced call to com/puppycrawl/tools/checkstyle/api/DetailNode::getParent with receiver</description> 
        
             <lineContent>DetailNode inlineTag = description.getParent();</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>JavadocTagContinuationIndentationCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagContinuationIndentationCheck</mutatedClass> 
        
             <mutatedMethod>isInlineDescription</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to com/puppycrawl/tools/checkstyle/api/DetailNode::getParent</description> 
        
             <lineContent>inlineTag = inlineTag.getParent();</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>JavadocTagContinuationIndentationCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagContinuationIndentationCheck</mutatedClass> 
        
             <mutatedMethod>isViolation</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator> 
        
             <description>removed conditional - replaced equality check with true</description> 
        
             <lineContent>if (CommonUtil.isBlank(text)) {</lineContent> 
        
           </mutation>

Explaination

loop run 1 time more

Regression

Report-1 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/b09decb_2023223713/reports/diff/index.html

Report-2 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/6e50bb5_2023174529/reports/diff/index.html

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/ec7b8b74e9e64a8a9f9c0014860b2016/raw/e392cb5c586eacde87601e6ef62098f95b8eba8f/JavadocTagContinuationIndentationCheck.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: Regression-2

Kevin222004 · 2023-08-20T19:51:10Z

Github, generate report

romani · 2023-08-20T20:33:27Z

@Kevin222004 , basic CI is red

github-actions · 2023-08-20T22:39:01Z

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/b09decb_2023223713/reports/diff/index.html

romani · 2023-08-21T03:54:56Z

Rebased to fix CI failure on ok comment

romani

ok to merge if reports are clean

Kevin222004 · 2023-08-21T15:47:33Z

Github, generate report

github-actions · 2023-08-21T17:46:15Z

Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/6e50bb5_2023174529/reports/diff/index.html

romani · 2023-08-21T17:59:03Z

@Kevin222004 , conflict

rdiachenko

lgtm

Vyom-Yadav

Item:

Vyom-Yadav · 2023-08-22T09:06:33Z

...a/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTagContinuationIndentationCheck.java

    private static boolean isInlineDescription(DetailNode description) {
        boolean isInline = false;
-        DetailNode inlineTag = description.getParent();
+        DetailNode inlineTag = description;


@Kevin222004 Can you please also change the name to currentNode as it is not an inlineTag node in every iteration, so makes less sense.

@Kevin222004 , please do.

…tationCheck2

romani force-pushed the JavadocTagContinuationIndentationCheck2 branch from b09decb to 8d03c9e Compare August 21, 2023 03:54

romani approved these changes Aug 21, 2023

View reviewed changes

romani requested review from Vyom-Yadav and rdiachenko August 21, 2023 13:06

romani assigned rdiachenko Aug 21, 2023

Kevin222004 force-pushed the JavadocTagContinuationIndentationCheck2 branch from 8d03c9e to 6e50bb5 Compare August 21, 2023 15:45

rdiachenko approved these changes Aug 21, 2023

View reviewed changes

rdiachenko assigned Vyom-Yadav and unassigned rdiachenko Aug 21, 2023

Kevin222004 force-pushed the JavadocTagContinuationIndentationCheck2 branch from 6e50bb5 to 5a90b57 Compare August 22, 2023 03:43

Vyom-Yadav suggested changes Aug 22, 2023

View reviewed changes

romani assigned romani and unassigned Vyom-Yadav Aug 22, 2023

Issue checkstyle#13501: Kill mutation for JavadocTagContinuationInden…

3d825c7

…tationCheck2

Kevin222004 force-pushed the JavadocTagContinuationIndentationCheck2 branch from 5a90b57 to 3d825c7 Compare August 22, 2023 17:27

romani approved these changes Aug 23, 2023

View reviewed changes

romani merged commit d949464 into checkstyle:master Aug 23, 2023

Kevin222004 mentioned this pull request Aug 29, 2023

Resolve pitest survivals in modules - 3 #13501

Closed

61 tasks

	<mutation unstable="false">
	<sourceFile>JavadocTagContinuationIndentationCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagContinuationIndentationCheck</mutatedClass>
	<mutatedMethod>isInlineDescription</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
	<description>replaced call to com/puppycrawl/tools/checkstyle/api/DetailNode::getParent with receiver</description>
	<lineContent>DetailNode inlineTag = description.getParent();</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>JavadocTagContinuationIndentationCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagContinuationIndentationCheck</mutatedClass>
	<mutatedMethod>isInlineDescription</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
	<description>removed call to com/puppycrawl/tools/checkstyle/api/DetailNode::getParent</description>
	<lineContent>inlineTag = inlineTag.getParent();</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>JavadocTagContinuationIndentationCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagContinuationIndentationCheck</mutatedClass>
	<mutatedMethod>isViolation</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator>
	<description>removed conditional - replaced equality check with true</description>
	<lineContent>if (CommonUtil.isBlank(text)) {</lineContent>
	</mutation>

Uh oh!

Conversation

Kevin222004 commented Aug 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Check

Mutation

Explaination

Regression

Uh oh!

Kevin222004 commented Aug 20, 2023

Uh oh!

romani commented Aug 20, 2023

Uh oh!

github-actions bot commented Aug 20, 2023

Uh oh!

romani commented Aug 21, 2023

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Kevin222004 commented Aug 21, 2023

Uh oh!

github-actions bot commented Aug 21, 2023

Uh oh!

romani commented Aug 21, 2023

Uh oh!

rdiachenko left a comment

Choose a reason for hiding this comment

Uh oh!

Vyom-Yadav left a comment

Choose a reason for hiding this comment

Uh oh!

Vyom-Yadav Aug 22, 2023

Choose a reason for hiding this comment

Uh oh!

romani Aug 22, 2023

Choose a reason for hiding this comment

Uh oh!

Kevin222004 Aug 22, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kevin222004 commented Aug 20, 2023 •

edited

Loading