Skip to content

Issue #13501: Kill mutation for JavadocTagContinuationIndentationCheck#13572

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:JavadocTagContinuationIndentationCheck1
Aug 21, 2023
Merged

Issue #13501: Kill mutation for JavadocTagContinuationIndentationCheck#13572
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:JavadocTagContinuationIndentationCheck1

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Aug 20, 2023 •
edited
Loading

Issue #13501: Kill mutation for JavadocTagContinuationIndentationCheck

Check

https://checkstyle.org/checks/javadoc/javadoctagcontinuationindentation.html#JavadocTagContinuationIndentation

Mutation

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 507 to 514 in d2c985e

<mutation unstable="false">
<sourceFile>JavadocTagContinuationIndentationCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagContinuationIndentationCheck</mutatedClass>
<mutatedMethod>getAllNewlineNodes</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
<description>replaced call to com/puppycrawl/tools/checkstyle/utils/JavadocUtil::getNextSibling with argument</description>
<lineContent>while (JavadocUtil.getNextSibling(node) != null) {</lineContent>
</mutation>

Explaination

Test added

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Aug 20, 2023

Github, generate report

romani
romani approved these changes Aug 20, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge if reports are clean

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Aug 20, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 20, 2023

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/63e374c_2023213024/reports/diff/index.html

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 20, 2023

Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/63e374c_2023224118/reports/diff/index.html

@romani
Copy link
Copy Markdown
Member

romani commented Aug 20, 2023

@Kevin222004 , CI is red

@romani
Copy link
Copy Markdown
Member

romani commented Aug 21, 2023

Rebased

@romani romani force-pushed the JavadocTagContinuationIndentationCheck1 branch from 63e374c to 0574414 Compare August 21, 2023 03:52
@romani
Copy link
Copy Markdown
Member

romani commented Aug 21, 2023

@Kevin222004 , hard CI failure https://ci.appveyor.com/project/Checkstyle/checkstyle/builds/47838603/job/9xejjdqxipvuk0ja#L322 after your update.

@Kevin222004 Kevin222004 force-pushed the JavadocTagContinuationIndentationCheck1 branch from 0574414 to 86966ea Compare August 21, 2023 15:45
@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Aug 21, 2023

@romani done test added

I have done some mistake while evaluating this

@romani romani merged commit 1310715 into checkstyle:master Aug 21, 2023
@Kevin222004 Kevin222004 mentioned this pull request Aug 21, 2023
Closed
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko Awaiting requested review from rdiachenko

@Vyom-Yadav Vyom-Yadav Awaiting requested review from Vyom-Yadav

Assignees

@rdiachenko rdiachenko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kevin222004 @romani @rdiachenko