Skip to content

Issue #13501: Kill mutation for JavadocTypeCheck2#13563

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:JavadocTypeCheck2
Aug 20, 2023
Merged

Issue #13501: Kill mutation for JavadocTypeCheck2#13563
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:JavadocTypeCheck2

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Aug 17, 2023 •
edited
Loading

Issue #13501: Kill mutation for JavadocTypeCheck2

Check

https://checkstyle.org/checks/javadoc/javadoctype.html#JavadocType

Mutation

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 597 to 613 in d2c985e

<mutation unstable="false">
<sourceFile>JavadocTypeCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTypeCheck</mutatedClass>
<mutatedMethod>shouldCheck</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to com/puppycrawl/tools/checkstyle/utils/AnnotationUtil::containsAnnotation</description>
<lineContent>&amp;&amp; !AnnotationUtil.containsAnnotation(ast, allowedAnnotations);</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>JavadocTypeCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTypeCheck</mutatedClass>
<mutatedMethod>shouldCheck</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator>
<description>removed conditional - replaced equality check with true</description>
<lineContent>&amp;&amp; !AnnotationUtil.containsAnnotation(ast, allowedAnnotations);</lineContent>
</mutation>

Explaination

Test added

Regression :-

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/e591a1cf82070108242c5569a7236a01/raw/9b17bf12fa20506af727bb7cae5c18b5b6dfe4ec/JavadocTypeCheck.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/21e3934e85f802e2fbd48af06d122364/raw/604256badd733d8568064f371d55657c04b00dfd/test-projects-2.properties
Report label: Regression-1

@Kevin222004 Kevin222004 marked this pull request as draft August 17, 2023 21:32
@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Aug 17, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 17, 2023

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/eb70428_2023233221/reports/diff/index.html

@Kevin222004 Kevin222004 marked this pull request as ready for review August 19, 2023 21:13
@Kevin222004 Kevin222004 mentioned this pull request Aug 20, 2023
Closed
61 tasks
@romani romani merged commit d93ccf1 into checkstyle:master Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kevin222004 @romani