Skip to content

Issue #13501: Kill mutation for NonEmptyAtclauseDescriptionCheck#13558

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:NonEmptyAtclauseDescriptionCheck
Aug 22, 2023
Merged

Issue #13501: Kill mutation for NonEmptyAtclauseDescriptionCheck#13558
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:NonEmptyAtclauseDescriptionCheck

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Aug 16, 2023

Issue #13501: Kill mutation for NonEmptyAtclauseDescriptionCheck

Check :-

https://checkstyle.org/checks/javadoc/nonemptyatclausedescription.html#NonEmptyAtclauseDescription

Mutation

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 696 to 704 in d2c985e

<mutation unstable="false">
<sourceFile>NonEmptyAtclauseDescriptionCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck</mutatedClass>
<mutatedMethod>visitJavadocToken</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to com/puppycrawl/tools/checkstyle/api/DetailNode::getText</description>
<lineContent>log(ast.getLineNumber(), MSG_KEY, ast.getText());</lineContent>
</mutation>

Explaination

Their is only one message key

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/NonEmptyAtclauseDescriptionCheck.java

Line 142 in d2c985e

public static final String MSG_KEY = "non.empty.atclause";

checkstyle/src/main/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/messages.properties

Line 33 in d2c985e

non.empty.atclause=At-clause should have a non-empty description.

not require ast.getText

@Kevin222004 Kevin222004 mentioned this pull request Aug 16, 2023
Closed
61 tasks
romani
romani approved these changes Aug 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge.
Double checked non of translation has parameter.

rdiachenko
rdiachenko approved these changes Aug 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko rdiachenko assigned Vyom-Yadav and unassigned rdiachenko Aug 17, 2023
Vyom-Yadav
Vyom-Yadav approved these changes Aug 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Vyom-Yadav Vyom-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vyom-Yadav Vyom-Yadav assigned romani and unassigned Vyom-Yadav Aug 22, 2023
@romani romani merged commit 67b51b8 into checkstyle:master Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

+1 more reviewer

@Vyom-Yadav Vyom-Yadav Vyom-Yadav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@romani romani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kevin222004 @romani @rdiachenko @Vyom-Yadav