Skip to content

Issue #13501: Kill mutation for RequireEmptyLineBeforeBlockTagGroupCheck#13557

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:Require1
Aug 22, 2023
Merged

Issue #13501: Kill mutation for RequireEmptyLineBeforeBlockTagGroupCheck#13557
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:Require1

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Aug 16, 2023 •
edited
Loading

Issue #13501: Kill mutation for RequireEmptyLineBeforeBlockTagGroup

Check :-

https://checkstyle.org/checks/javadoc/requireemptylinebeforeblocktaggroup.html#RequireEmptyLineBeforeBlockTagGroup

Mutation

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 705 to 712 in d2c985e

<mutation unstable="false">
<sourceFile>RequireEmptyLineBeforeBlockTagGroupCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.RequireEmptyLineBeforeBlockTagGroupCheck</mutatedClass>
<mutatedMethod>hasInsufficientConsecutiveNewlines</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_ORDER_IF</mutator>
<description>removed conditional - replaced comparison check with true</description>
<lineContent>while (count &lt;= 1</lineContent>
</mutation>

Explaination

The removed condition is only for break (Bad side affect)

Regression :-

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/9ee46058f8167a1f6118a5fa7f3baf1f/raw/ad9ecf2e08cafdecfc1d16ada9430e4fbd8f77a6/RequireEmptyLineBeforeBlockTagGroup.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: Regression-2

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Aug 16, 2023

Github, generate report

@Kevin222004 Kevin222004 mentioned this pull request Jul 27, 2023
Closed
@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Aug 16, 2023

Github, generate report

@Kevin222004 Kevin222004 mentioned this pull request Aug 16, 2023
Closed
61 tasks
rdiachenko
rdiachenko approved these changes Aug 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 16, 2023

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/98ca384_2023212121/reports/diff/index.html

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 16, 2023

Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/98ca384_2023223026/reports/diff/index.html

romani
romani approved these changes Aug 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, pitest is micro-performance killer.

But I hope our feedback to pitest project can help to improve it to skip mutation that are in loops expression.

Vyom-Yadav
Vyom-Yadav approved these changes Aug 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Vyom-Yadav Vyom-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I wonder if there is some testing framework to have granular control over time complexity. All I could find was some ideas and most of the folks using time in millis to do shallow testing.

@Vyom-Yadav Vyom-Yadav assigned romani and unassigned Vyom-Yadav Aug 22, 2023
@romani romani merged commit 2302bbb into checkstyle:master Aug 22, 2023
@Kevin222004 Kevin222004 mentioned this pull request Jan 23, 2024
Closed
@Kevin222004 Kevin222004 mentioned this pull request Jan 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

+1 more reviewer

@Vyom-Yadav Vyom-Yadav Vyom-Yadav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@romani romani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kevin222004 @romani @rdiachenko @Vyom-Yadav