Skip to content

Issue #13501: Kill mutation for MultilineDetector#13549

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:MultiLineDetector
Aug 22, 2023
Merged

Issue #13501: Kill mutation for MultilineDetector#13549
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:MultiLineDetector

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Aug 14, 2023 •
edited
Loading

Issue #13501: Kill mutation for MultilineDetector

Mutation

checkstyle/config/pitest-suppressions/pitest-regexp-suppressions.xml

Lines 4 to 11 in 8134680

<mutation unstable="false">
<sourceFile>MultilineDetector.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.regexp.MultilineDetector</mutatedClass>
<mutatedMethod>findMatch</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to java/util/regex/Pattern::toString</description>
<lineContent>options.getReporter().log(1, MSG_STACKOVERFLOW, matcher.pattern().toString());</lineContent>
</mutation>

@romani romani self-assigned this Aug 15, 2023
@romani
Copy link
Copy Markdown
Member

romani commented Aug 18, 2023

@Kevin222004 , please fix index in message.

romani
romani approved these changes Aug 20, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch of defect.

Ok to merge.

@romani romani requested a review from rdiachenko August 20, 2023 14:59
@romani romani assigned rdiachenko and unassigned romani Aug 20, 2023
@romani romani requested a review from Vyom-Yadav August 20, 2023 15:00
rdiachenko
rdiachenko approved these changes Aug 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko rdiachenko assigned Vyom-Yadav and unassigned rdiachenko Aug 21, 2023
Vyom-Yadav
Vyom-Yadav approved these changes Aug 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Vyom-Yadav Vyom-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vyom-Yadav Vyom-Yadav assigned romani and unassigned Vyom-Yadav Aug 22, 2023
@romani romani merged commit f274bdd into checkstyle:master Aug 22, 2023
@Kevin222004 Kevin222004 mentioned this pull request Aug 22, 2023
Closed
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

+1 more reviewer

@Vyom-Yadav Vyom-Yadav Vyom-Yadav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@romani romani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kevin222004 @romani @rdiachenko @Vyom-Yadav