Skip to content

Issue #13501: Kill mutation for AtclauseOrder#13515

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:AT
Aug 9, 2023
Merged

Issue #13501: Kill mutation for AtclauseOrder#13515
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:AT

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Aug 5, 2023 •
edited
Loading

Issue #13501: Kill mutation for AtclauseOrder

Check

https://checkstyle.org/checks/javadoc/atclauseorder.html#AtclauseOrder

Mutation

checkstyle/config/pitest-suppressions/pitest-javadoc-suppressions.xml

Lines 66 to 73 in 7e879f3

<mutation unstable="false">
<sourceFile>AtclauseOrderCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.AtclauseOrderCheck</mutatedClass>
<mutatedMethod>setTagOrder</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
<description>replaced call to java/lang/String::trim with receiver</description>
<lineContent>customOrder.add(order.trim());</lineContent>
</mutation>

Explaination

The tags go trimmed at

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/AbstractAutomaticBean.java

Lines 368 to 371 in 7e879f3

public Object convert(Class type, Object value) {
final StringTokenizer tokenizer = new StringTokenizer(
value.toString().trim(), COMMA_SEPARATOR);
final List<String> result = new ArrayList<>();

before setToken

Regression

Overview
no diff

Report-1 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/c9ee9e2_2023120752/reports/diff/index.html

Report-2 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/c9ee9e2_2023180229/reports/diff/index.html

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/b55841e291e59cfec63ffb63dc635840/raw/5ca37f4703a35b84dfc4e5fcaf52dcc95b11c710/Atclause.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: Report-2

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Aug 5, 2023

Github, generate report

@Kevin222004 Kevin222004 mentioned this pull request Aug 5, 2023
Closed
61 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 5, 2023

Report-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/c9ee9e2_2023120752/reports/diff/index.html

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Aug 5, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 5, 2023

Report-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/c9ee9e2_2023180229/reports/diff/index.html

romani
romani requested changes Aug 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pitest killing is correct.

small item:

@romani romani self-assigned this Aug 7, 2023
@romani romani requested review from Vyom-Yadav and rdiachenko August 7, 2023 00:45
@Kevin222004 Kevin222004 force-pushed the AT branch 2 times, most recently from eee511d to 7f83d59 Compare August 7, 2023 04:55
@romani
Copy link
Copy Markdown
Member

romani commented Aug 7, 2023

CI is failing

romani
romani approved these changes Aug 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani assigned Vyom-Yadav and unassigned romani Aug 7, 2023
rdiachenko
rdiachenko approved these changes Aug 8, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Vyom-Yadav
Vyom-Yadav approved these changes Aug 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Vyom-Yadav Vyom-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romani romani merged commit 70c6328 into checkstyle:master Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

+1 more reviewer

@Vyom-Yadav Vyom-Yadav Vyom-Yadav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@romani romani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kevin222004 @romani @rdiachenko @Vyom-Yadav