Skip to content

Issue #13321: Kill mutation for ScopeUtil-3#13481

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:su3
Aug 9, 2023
Merged

Issue #13321: Kill mutation for ScopeUtil-3#13481
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:su3

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jul 29, 2023 •
edited
Loading

Issue #13321: Kill mutation for ScopeUtil-3

Mutation

checkstyle/config/pitest-suppressions/pitest-utils-suppressions.xml

Lines 336 to 343 in bb64c20

<mutation unstable="false">
<sourceFile>ScopeUtil.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.utils.ScopeUtil</mutatedClass>
<mutatedMethod>isInEnumBlock</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator>
<description>removed conditional - replaced equality check with true</description>
<lineContent>token != null &amp;&amp; !returnValue;</lineContent>
</mutation>

Explaination

The logic has not been changed. only design is changed

The reason to not follow pitest is we can do it in less time-complexity by following my changes. :)

Regression

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/63cd42f1f26093d981dad219eb8986eb/raw/4cc3d4b44b54b551ceb2f723c0dff753d548f7ff/su3.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: Regression-2

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 29, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 29, 2023

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/be7853e_2023131242/reports/diff/index.html

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 29, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 29, 2023

Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/be7853e_2023174507/reports/diff/index.html

@Kevin222004 Kevin222004 force-pushed the su3 branch 3 times, most recently from 573382a to f41ccfe Compare August 5, 2023 20:25
@Kevin222004 Kevin222004 marked this pull request as ready for review August 5, 2023 20:25
@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Aug 5, 2023

@romani ready for review

romani
romani approved these changes Aug 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactoring

@romani
Copy link
Copy Markdown
Member

romani commented Aug 5, 2023

@Kevin222004 , please fix CI.

@romani romani requested a review from rdiachenko August 5, 2023 20:57
rdiachenko
rdiachenko approved these changes Aug 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko rdiachenko assigned Vyom-Yadav and unassigned rdiachenko Aug 6, 2023
@Kevin222004 Kevin222004 mentioned this pull request Aug 7, 2023
Closed
61 tasks
Vyom-Yadav
Vyom-Yadav approved these changes Aug 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Vyom-Yadav Vyom-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vyom-Yadav Vyom-Yadav assigned romani and unassigned Vyom-Yadav Aug 9, 2023
@romani
Copy link
Copy Markdown
Member

romani commented Aug 9, 2023

@Kevin222004 , please resolve conflict

@romani romani merged commit 68aee0a into checkstyle:master Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

+1 more reviewer

@Vyom-Yadav Vyom-Yadav Vyom-Yadav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@romani romani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kevin222004 @romani @rdiachenko @Vyom-Yadav