Skip to content

Issue #13321: Kill mutation for JavadocUtil#13477

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:cu3
Jul 30, 2023
Merged

Issue #13321: Kill mutation for JavadocUtil#13477
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:cu3

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jul 28, 2023

Issue #13321: Kill mutation for JavadocUtil

Mutation

checkstyle/config/pitest-suppressions/pitest-utils-suppressions.xml

Lines 291 to 299 in bb64c20

<mutation unstable="false">
<sourceFile>JavadocUtil.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.utils.JavadocUtil</mutatedClass>
<mutatedMethod>containsInBranch</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to com/puppycrawl/tools/checkstyle/api/DetailNode::getParent</description>
<lineContent>curNode = curNode.getParent();</lineContent>
</mutation>

Explaination

Their is no usage of this method in whole codebase

@Kevin222004 Kevin222004 force-pushed the cu3 branch 2 times, most recently from 84fff55 to 89a9ca5 Compare July 28, 2023 16:44
@nrmancuso nrmancuso requested a review from romani July 29, 2023 18:18
@nrmancuso
Copy link
Copy Markdown
Contributor

nrmancuso commented Jul 29, 2023

I am good to merge, this is internal utility method.

romani
romani requested changes Jul 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal is good.

Items:

romani
romani approved these changes Jul 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani assigned rdiachenko and unassigned romani Jul 30, 2023
@romani
Copy link
Copy Markdown
Member

romani commented Jul 30, 2023

I merging, as we just remove whole method.

@romani romani merged commit 74dc9ef into checkstyle:master Jul 30, 2023
@Kevin222004 Kevin222004 mentioned this pull request Oct 24, 2023
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

+1 more reviewer

@nrmancuso nrmancuso nrmancuso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rdiachenko rdiachenko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kevin222004 @nrmancuso @romani @rdiachenko