Issue #13501: Kill mutation for CommonUtil-2 by Kevin222004 · Pull Request #13475 · checkstyle/checkstyle

Kevin222004 · 2023-07-27T18:51:30Z

Issue #13501: Kill mutation for CommonUtil-2

Mutation

checkstyle/config/pitest-suppressions/pitest-utils-suppressions.xml

Lines 246 to 262 in bb64c20

    
           <mutation unstable="false"> 
        
             <sourceFile>CommonUtil.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.utils.CommonUtil</mutatedClass> 
        
             <mutatedMethod>isName</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to java/lang/String::isEmpty</description> 
        
             <lineContent>boolean isName = !str.isEmpty();</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>CommonUtil.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.utils.CommonUtil</mutatedClass> 
        
             <mutatedMethod>isName</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator> 
        
             <description>removed conditional - replaced equality check with true</description> 
        
             <lineContent>boolean isName = !str.isEmpty();</lineContent> 
        
           </mutation>

Explaination

This method is used in

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/metrics/AbstractClassCouplingCheck.java

Lines 173 to 175 in f9df519

    
           public final void setExcludedPackages(String... excludedPackages) { 
        
               final List<String> invalidIdentifiers = Arrays.stream(excludedPackages) 
        
                   .filter(Predicate.not(CommonUtil::isName))

This method is used to set the property excludedPackages lets suppose if it is set empty then in filter commonUtil.isName never be call so the string never be empty it always true

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/ccd588c72cd541ff98736f08dc687e43/raw/28c14aa0fdf848a5191761ffe4cbbea8c860a0a9/gist.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: New-Regression-2

Kevin222004 · 2023-07-27T18:59:40Z

Github, generate report

github-actions · 2023-07-27T20:23:23Z

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/7bb7207_2023202249/reports/diff/index.html

Kevin222004 · 2023-07-27T20:25:03Z

Github, generate report

github-actions · 2023-07-27T22:23:08Z

Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/7bb7207_2023222148/reports/diff/index.html

nrmancuso

Item:

src/main/java/com/puppycrawl/tools/checkstyle/utils/CommonUtil.java

Kevin222004 · 2023-08-07T07:31:18Z

Github, generate report

github-actions · 2023-08-07T11:27:24Z

New-Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/383b532_2023095954/reports/diff/index.html

Kevin222004 · 2023-08-07T11:44:18Z

Github, generate report

romani

Ok to merge if ci and reports are good

github-actions · 2023-08-07T17:01:50Z

New-Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e9575f4_2023165850/reports/diff/index.html

rdiachenko

lgtm

Vyom-Yadav

LGTM!

nrmancuso suggested changes Jul 29, 2023

View reviewed changes

src/main/java/com/puppycrawl/tools/checkstyle/utils/CommonUtil.java Outdated Show resolved Hide resolved

nrmancuso self-assigned this Jul 29, 2023

romani assigned romani and unassigned nrmancuso Jul 30, 2023

romani mentioned this pull request Jul 31, 2023

Issue #13411: Fix NPE in UnnecessarySemicolonAfterTypeMemberDeclarationCheck #13486

Merged

Kevin222004 force-pushed the cu2 branch from 7bb7207 to 383b532 Compare August 7, 2023 07:30

Kevin222004 mentioned this pull request Aug 7, 2023

Resolve pitest survivals in modules - 3 #13501

Closed

61 tasks

Kevin222004 changed the title ~~Issue #13321: Kill mutation for CommonUtil-2~~ Issue #13501: Kill mutation for CommonUtil-2 Aug 7, 2023

Issue checkstyle#13501: Kill mutation for CommonUtil-2

e9575f4

Kevin222004 force-pushed the cu2 branch from 383b532 to e9575f4 Compare August 7, 2023 08:42

romani approved these changes Aug 7, 2023

View reviewed changes

romani assigned nrmancuso and unassigned romani Aug 7, 2023

romani requested review from Vyom-Yadav and rdiachenko August 7, 2023 14:41

nrmancuso approved these changes Aug 8, 2023

View reviewed changes

nrmancuso assigned Vyom-Yadav and unassigned nrmancuso Aug 8, 2023

rdiachenko approved these changes Aug 8, 2023

View reviewed changes

Vyom-Yadav approved these changes Aug 9, 2023

View reviewed changes

Vyom-Yadav assigned romani and unassigned Vyom-Yadav Aug 9, 2023

romani merged commit 3dc2cad into checkstyle:master Aug 9, 2023

	<mutation unstable="false">
	<sourceFile>CommonUtil.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.utils.CommonUtil</mutatedClass>
	<mutatedMethod>isName</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
	<description>removed call to java/lang/String::isEmpty</description>
	<lineContent>boolean isName = !str.isEmpty();</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>CommonUtil.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.utils.CommonUtil</mutatedClass>
	<mutatedMethod>isName</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator>
	<description>removed conditional - replaced equality check with true</description>
	<lineContent>boolean isName = !str.isEmpty();</lineContent>
	</mutation>

	public final void setExcludedPackages(String... excludedPackages) {
	final List<String> invalidIdentifiers = Arrays.stream(excludedPackages)
	.filter(Predicate.not(CommonUtil::isName))

Uh oh!

Conversation

Kevin222004 commented Jul 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mutation

Explaination

Uh oh!

Kevin222004 commented Jul 27, 2023

Uh oh!

github-actions bot commented Jul 27, 2023

Uh oh!

Kevin222004 commented Jul 27, 2023

Uh oh!

github-actions bot commented Jul 27, 2023

Uh oh!

nrmancuso left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Kevin222004 commented Aug 7, 2023

Uh oh!

github-actions bot commented Aug 7, 2023

Uh oh!

Kevin222004 commented Aug 7, 2023

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 7, 2023

Uh oh!

rdiachenko left a comment

Choose a reason for hiding this comment

Uh oh!

Vyom-Yadav left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Kevin222004 commented Jul 27, 2023 •

edited

Loading