Issue #13501: Kill mutation for CodePointUtil by Kevin222004 · Pull Request #13473 · checkstyle/checkstyle

Kevin222004 · 2023-07-27T17:27:56Z

Issue #13501: Kill mutation for CodePointUtil

Mutation introduction at b862853
@nrmancuso is mandatory reviewer, as we allowed this code in PR year ago.

Mutations

checkstyle/config/pitest-suppressions/pitest-utils-suppressions.xml

Lines 174 to 226 in bb64c20

    
           <mutation unstable="false"> 
        
             <sourceFile>CodePointUtil.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.utils.CodePointUtil</mutatedClass> 
        
             <mutatedMethod>stripLeading</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to com/puppycrawl/tools/checkstyle/utils/CommonUtil::isCodePointWhitespace</description> 
        
             <lineContent>&amp;&amp; CommonUtil.isCodePointWhitespace(codePoints, startIndex)) {</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>CodePointUtil.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.utils.CodePointUtil</mutatedClass> 
        
             <mutatedMethod>stripLeading</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator> 
        
             <description>removed conditional - replaced equality check with false</description> 
        
             <lineContent>&amp;&amp; CommonUtil.isCodePointWhitespace(codePoints, startIndex)) {</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>CodePointUtil.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.utils.CodePointUtil</mutatedClass> 
        
             <mutatedMethod>stripLeading</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator> 
        
             <description>replaced call to java/util/Arrays::copyOfRange with argument</description> 
        
             <lineContent>return Arrays.copyOfRange(codePoints, startIndex, codePoints.length);</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>CodePointUtil.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.utils.CodePointUtil</mutatedClass> 
        
             <mutatedMethod>stripLeading</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_ORDER_ELSE</mutator> 
        
             <description>removed conditional - replaced comparison check with false</description> 
        
             <lineContent>while (startIndex &lt; codePoints.length</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>CodePointUtil.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.utils.CodePointUtil</mutatedClass> 
        
             <mutatedMethod>trim</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator> 
        
             <description>replaced call to com/puppycrawl/tools/checkstyle/utils/CodePointUtil::stripTrailing with argument</description> 
        
             <lineContent>final int[] strippedCodePoints = stripTrailing(codePoints);</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>CodePointUtil.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.utils.CodePointUtil</mutatedClass> 
        
             <mutatedMethod>trim</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator> 
        
             <description>replaced call to com/puppycrawl/tools/checkstyle/utils/CodePointUtil::stripLeading with argument</description> 
        
             <lineContent>return stripLeading(strippedCodePoints);</lineContent> 
        
           </mutation>

Explaintaion

Both the method

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/utils/CodePointUtil.java

Lines 64 to 70 in 79e7609

    
           public static int[] stripTrailing(int... codePoints) { 
        
               int lastIndex = codePoints.length; 
        
               while (lastIndex > 0 && CommonUtil.isCodePointWhitespace(codePoints, lastIndex - 1)) { 
        
                   lastIndex--; 
        
               } 
        
               return Arrays.copyOfRange(codePoints, 0, lastIndex); 
        
           }

and

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/utils/CodePointUtil.java

Lines 78 to 86 in 79e7609

    
           public static int[] stripLeading(int... codePoints) { 
        
               int startIndex = 0; 
        
               while (startIndex < codePoints.length 
        
                   && CommonUtil.isCodePointWhitespace(codePoints, startIndex)) { 
        
                   startIndex++; 
        
               } 
        
               return Arrays.copyOfRange(codePoints, startIndex, codePoints.length); 
        
           }

are same only logic has written differently.
in stripTrailing method loop start from lastIndex of array and finsih at index 0 and same but opposite in stripLeading
the condition of loop is isCodePointWhitespace(codePoints, startIndex) will fail in both the method if their is no whitespace

Regression

Report-1 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2237062_2023171438/reports/diff/index.html

Report-2 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2237062_2023180212/reports/diff/index.html

Report-3 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2237062_2023191958/reports/diff/index.html

Report-4 :-

Report-5 :-

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/66e91526d84b11d76ed35dc61f651108/raw/01d1012ebdb5cae259e1f1775c9b25d68c41c881/codeutil2.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/2207ddd139a1721d00b0e6b312bc3f03/raw/a0b63175830fccda7c242058d8f513d61d4dce0d/util1.properties
Report label: Aug-28-2.2

Kevin222004 · 2023-07-27T17:31:14Z

Github, generate report

github-actions · 2023-07-27T20:25:46Z

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/5683659916

Kevin222004 · 2023-07-27T20:34:02Z

Github, generate report

github-actions · 2023-07-27T21:46:47Z

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/5685212717

Kevin222004 · 2023-07-29T16:47:02Z

Github, generate report

github-actions · 2023-07-29T18:33:27Z

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/5ed911e_2023180325/reports/diff/index.html

Kevin222004 · 2023-08-04T09:42:20Z

Github, generate report

github-actions · 2023-08-04T09:48:17Z

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/5ed911e_2023094759/reports/diff/index.html

Kevin222004 · 2023-08-04T15:45:18Z

Github, generate report

github-actions · 2023-08-04T15:51:52Z

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/5ed911e_2023155135/reports/diff/index.html

Kevin222004 · 2023-08-09T04:52:38Z

Github, generate report

github-actions · 2023-08-09T05:12:11Z

Aug-9-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/1c7cdf4_2023051149/reports/diff/index.html

Kevin222004 · 2023-08-09T08:37:30Z

Github, generate report

github-actions · 2023-08-09T09:30:30Z

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/5806791567

Kevin222004 · 2023-08-15T17:51:27Z

Github, generate report

github-actions · 2023-08-15T20:03:10Z

Report generation failed on phase ,
step .
Link: https://github.com/checkstyle/checkstyle/actions/runs/5870108880

Kevin222004 · 2023-08-16T05:23:09Z

@romani please re-run pitest-common

https://github.com/checkstyle/checkstyle/actions/runs/5870097408/job/15916453617?pr=13473#step:7:15

+  <mutation unstable="false">
+    <sourceFile>Checker.java</sourceFile>
+    <mutatedClass>com.puppycrawl.tools.checkstyle.Checker</mutatedClass>
+    <mutatedMethod>finishLocalSetup</mutatedMethod>
+    <mutator>org.pitest.mutationtest.engine.gregor.mutators.VoidMethodCallMutator</mutator>
+    <description>removed call to com/puppycrawl/tools/checkstyle/LocalizedMessage::setLocale</description>
+    <lineContent>LocalizedMessage.setLocale(locale);</lineContent>
+  </mutation>
+

romani · 2023-08-16T05:27:33Z

Relaunched

src/main/java/com/puppycrawl/tools/checkstyle/utils/CodePointUtil.java

Kevin222004 · 2023-08-24T19:40:03Z

Github, generate report

nrmancuso

Please rearrange declaration order and order of usage to be the same, ex:

boolean x = ...;
boolean y = ...;

if (x) {
...
} else if (y) {
...
}

Items:

src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/SeparatorWrapCheck.java

github-actions · 2023-08-24T20:46:55Z

Aug-20-2-2.4:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/f72627c_2023204608/reports/diff/index.html

Kevin222004 · 2023-08-25T15:11:42Z

Github, generate report

github-actions · 2023-08-26T00:53:44Z

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/5977518342

nrmancuso · 2023-08-26T04:44:08Z

@Kevin222004 please make CI happy

Kevin222004 · 2023-08-26T07:17:08Z

Github, generate report

github-actions · 2023-08-26T07:40:49Z

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/5983524217

Kevin222004 · 2023-08-26T07:44:54Z

Github, generate report

github-actions · 2023-08-26T08:07:39Z

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/5983618901

romani · 2023-08-28T05:02:11Z

@Kevin222004 , please generate report

Kevin222004 · 2023-08-28T15:24:54Z

Github, generate report

github-actions · 2023-08-28T17:15:45Z

Aug-28-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2237062_2023171438/reports/diff/index.html

Kevin222004 · 2023-08-28T17:26:19Z

Github, generate report

github-actions · 2023-08-28T18:02:36Z

Aug-28-2.1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2237062_2023180212/reports/diff/index.html

Kevin222004 · 2023-08-28T18:49:37Z

Github, generate report

github-actions · 2023-08-28T19:20:27Z

Aug-28-2.2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2237062_2023191958/reports/diff/index.html

Kevin222004 · 2023-08-28T20:09:12Z

Github, generate report

romani

Ok to merge

Kevin222004 marked this pull request as draft July 27, 2023 17:32

Kevin222004 force-pushed the cp1 branch from 5ed911e to 1c7cdf4 Compare August 9, 2023 04:51

Kevin222004 force-pushed the cp1 branch from 1c7cdf4 to 4378ebe Compare August 9, 2023 08:36

Kevin222004 changed the title ~~Issue #13321: Kill mutation for CodePointUtil~~ Issue #13501: Kill mutation for CodePointUtil Aug 15, 2023

Kevin222004 force-pushed the cp1 branch from 4378ebe to 074d6f1 Compare August 15, 2023 17:49

Kevin222004 marked this pull request as ready for review August 15, 2023 17:51

Kevin222004 mentioned this pull request Aug 15, 2023

Resolve pitest survivals in modules - 3 #13501

Closed

61 tasks

romani requested review from Vyom-Yadav, rdiachenko and romani August 15, 2023 23:26

romani assigned rdiachenko Aug 15, 2023

rdiachenko reviewed Aug 16, 2023

View reviewed changes

src/main/java/com/puppycrawl/tools/checkstyle/utils/CodePointUtil.java Outdated Show resolved Hide resolved

Kevin222004 force-pushed the cp1 branch from 3846f67 to f72627c Compare August 24, 2023 19:38

nrmancuso suggested changes Aug 24, 2023

View reviewed changes

src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/SeparatorWrapCheck.java Outdated Show resolved Hide resolved

src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/SeparatorWrapCheck.java Outdated Show resolved Hide resolved

Kevin222004 force-pushed the cp1 branch from f72627c to ccdca6f Compare August 25, 2023 15:11

Issue checkstyle#13501: Kill mutation for CodePointUtil

2237062

Kevin222004 force-pushed the cp1 branch from ccdca6f to 2237062 Compare August 26, 2023 16:02

nrmancuso approved these changes Aug 28, 2023

View reviewed changes

nrmancuso assigned Vyom-Yadav and unassigned nrmancuso Aug 28, 2023

romani removed the request for review from Vyom-Yadav August 29, 2023 04:49

romani assigned romani and unassigned Vyom-Yadav Aug 29, 2023

romani approved these changes Aug 29, 2023

View reviewed changes

romani merged commit 54649c9 into checkstyle:master Aug 29, 2023

	<mutation unstable="false">
	<sourceFile>CodePointUtil.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.utils.CodePointUtil</mutatedClass>
	<mutatedMethod>stripLeading</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
	<description>removed call to com/puppycrawl/tools/checkstyle/utils/CommonUtil::isCodePointWhitespace</description>
	<lineContent>&& CommonUtil.isCodePointWhitespace(codePoints, startIndex)) {</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>CodePointUtil.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.utils.CodePointUtil</mutatedClass>
	<mutatedMethod>stripLeading</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator>
	<description>removed conditional - replaced equality check with false</description>
	<lineContent>&& CommonUtil.isCodePointWhitespace(codePoints, startIndex)) {</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>CodePointUtil.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.utils.CodePointUtil</mutatedClass>
	<mutatedMethod>stripLeading</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
	<description>replaced call to java/util/Arrays::copyOfRange with argument</description>
	<lineContent>return Arrays.copyOfRange(codePoints, startIndex, codePoints.length);</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>CodePointUtil.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.utils.CodePointUtil</mutatedClass>
	<mutatedMethod>stripLeading</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_ORDER_ELSE</mutator>
	<description>removed conditional - replaced comparison check with false</description>
	<lineContent>while (startIndex < codePoints.length</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>CodePointUtil.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.utils.CodePointUtil</mutatedClass>
	<mutatedMethod>trim</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
	<description>replaced call to com/puppycrawl/tools/checkstyle/utils/CodePointUtil::stripTrailing with argument</description>
	<lineContent>final int[] strippedCodePoints = stripTrailing(codePoints);</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>CodePointUtil.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.utils.CodePointUtil</mutatedClass>
	<mutatedMethod>trim</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
	<description>replaced call to com/puppycrawl/tools/checkstyle/utils/CodePointUtil::stripLeading with argument</description>
	<lineContent>return stripLeading(strippedCodePoints);</lineContent>
	</mutation>

	public static int[] stripTrailing(int... codePoints) {
	int lastIndex = codePoints.length;
	while (lastIndex > 0 && CommonUtil.isCodePointWhitespace(codePoints, lastIndex - 1)) {
	lastIndex--;
	}
	return Arrays.copyOfRange(codePoints, 0, lastIndex);
	}

	public static int[] stripLeading(int... codePoints) {
	int startIndex = 0;
	while (startIndex < codePoints.length
	&& CommonUtil.isCodePointWhitespace(codePoints, startIndex)) {
	startIndex++;
	}
	return Arrays.copyOfRange(codePoints, startIndex, codePoints.length);
	}

Uh oh!

Conversation

Kevin222004 commented Jul 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mutations

Explaintaion

Regression

Uh oh!

Kevin222004 commented Jul 27, 2023

Uh oh!

github-actions bot commented Jul 27, 2023

Uh oh!

Kevin222004 commented Jul 27, 2023

Uh oh!

github-actions bot commented Jul 27, 2023

Uh oh!

Kevin222004 commented Jul 29, 2023

Uh oh!

github-actions bot commented Jul 29, 2023

Uh oh!

Kevin222004 commented Aug 4, 2023

Uh oh!

github-actions bot commented Aug 4, 2023

Uh oh!

Kevin222004 commented Aug 4, 2023

Uh oh!

github-actions bot commented Aug 4, 2023

Uh oh!

Kevin222004 commented Aug 9, 2023

Uh oh!

github-actions bot commented Aug 9, 2023

Uh oh!

Kevin222004 commented Aug 9, 2023

Uh oh!

github-actions bot commented Aug 9, 2023

Uh oh!

Kevin222004 commented Aug 15, 2023

Uh oh!

github-actions bot commented Aug 15, 2023

Uh oh!

Kevin222004 commented Aug 16, 2023 • edited by romani Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

romani commented Aug 16, 2023

Uh oh!

Uh oh!

Kevin222004 commented Aug 24, 2023

Uh oh!

nrmancuso left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 24, 2023

Uh oh!

Kevin222004 commented Aug 25, 2023

Uh oh!

github-actions bot commented Aug 26, 2023

Uh oh!

nrmancuso commented Aug 26, 2023

Uh oh!

Kevin222004 commented Aug 26, 2023

Uh oh!

github-actions bot commented Aug 26, 2023

Uh oh!

Kevin222004 commented Aug 26, 2023

Uh oh!

github-actions bot commented Aug 26, 2023

Uh oh!

romani commented Aug 28, 2023

Uh oh!

Kevin222004 commented Aug 28, 2023

Uh oh!

github-actions bot commented Aug 28, 2023

Uh oh!

Kevin222004 commented Aug 28, 2023

Uh oh!

github-actions bot commented Aug 28, 2023

Uh oh!

Kevin222004 commented Aug 28, 2023

Kevin222004 commented Jul 27, 2023 •

edited

Loading

Kevin222004 commented Aug 16, 2023 •

edited by romani

Loading