Skip to content

Issue #13321: Kill mutation for CheckUtil-3#13430

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:cut3
Aug 3, 2023
Merged

Issue #13321: Kill mutation for CheckUtil-3#13430
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:cut3

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jul 24, 2023 •
edited
Loading

Issue #13321: Kill mutation for CheckUtil-3

Mutation

checkstyle/config/pitest-suppressions/pitest-utils-suppressions.xml

Lines 57 to 73 in f4a33f9

<mutation unstable="false">
<sourceFile>CheckUtil.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.utils.CheckUtil</mutatedClass>
<mutatedMethod>getShortNameOfAnonInnerClass</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
<description>replaced call to com/puppycrawl/tools/checkstyle/api/DetailAST::getParent with receiver</description>
<lineContent>DetailAST parentAst = literalNewAst.getParent();</lineContent>
</mutation>
<mutation unstable="false">
<sourceFile>CheckUtil.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.utils.CheckUtil</mutatedClass>
<mutatedMethod>getSurroundingAccessModifier</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
<description>replaced call to com/puppycrawl/tools/checkstyle/api/DetailAST::getParent with receiver</description>
<lineContent>for (DetailAST token = node.getParent();</lineContent>
</mutation>

Explaination

loop run 1 time more

Regression :-

Report-1 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e3b2e2a_2023230520/reports/diff/index.html

Report-2 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e3b2e2a_2023062205/reports/diff/index.html

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/b64bf63db7a5fb640a79fd489180d853/raw/3f60390b4addc0a147b265b4220f1dc22b82a164/loop.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: Regression-2

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 24, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 24, 2023

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e3b2e2a_2023230520/reports/diff/index.html

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 25, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 25, 2023

Regression-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e3b2e2a_2023062205/reports/diff/index.html

This was referenced Jul 22, 2023
Closed
Closed
rdiachenko
rdiachenko approved these changes Jul 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

romani
romani approved these changes Jul 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge.

@Kevin222004 , please keep adding such cases to our report of unfortunate cases

Vyom-Yadav
Vyom-Yadav approved these changes Aug 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Vyom-Yadav Vyom-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vyom-Yadav Vyom-Yadav assigned romani and unassigned Vyom-Yadav Aug 1, 2023
@Kevin222004 Kevin222004 mentioned this pull request Aug 2, 2023
Closed
@romani
Copy link
Copy Markdown
Member

romani commented Aug 3, 2023

Semaphore was restarted

@romani romani merged commit 71fada3 into checkstyle:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

+1 more reviewer

@Vyom-Yadav Vyom-Yadav Vyom-Yadav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@romani romani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kevin222004 @romani @rdiachenko @Vyom-Yadav