Skip to content

Issue #13321: Kill mutation for BlockCommentPosition#13416

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:ut3
Aug 3, 2023
Merged

Issue #13321: Kill mutation for BlockCommentPosition#13416
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:ut3

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jul 22, 2023 •
edited
Loading

Issue #13321: Kill mutation for BlockCommentPosition

Mutations

checkstyle/config/pitest-suppressions/pitest-utils-suppressions.xml

Lines 12 to 19 in 8804126

<mutation unstable="false">
<sourceFile>BlockCommentPosition.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.utils.BlockCommentPosition</mutatedClass>
<mutatedMethod>getNextSiblingSkipComments</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
<description>replaced call to com/puppycrawl/tools/checkstyle/api/DetailAST::getNextSibling with receiver</description>
<lineContent>DetailAST result = node.getNextSibling();</lineContent>
</mutation>

Explaination

Loops run 1 time more

Regression

Report-1 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/87515e8_2023123322/reports/diff/index.html

Report-2 :- https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/87515e8_2023161333/reports/diff/index.html

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/0582e64583a72448d7460e5e14ff1ac2/raw/ba487c241253f94d16b864e2556d956285a27727/BlockUtil.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: R-2

@Kevin222004 Kevin222004 mentioned this pull request Jul 22, 2023
Closed
@romani
Copy link
Copy Markdown
Member

romani commented Jul 22, 2023

Failing CI restarted.
Please share reports.

@Kevin222004 Kevin222004 mentioned this pull request Jul 22, 2023
Closed
41 tasks
@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 24, 2023

Github, generate report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 24, 2023

R-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/87515e8_2023123322/reports/diff/index.html

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 24, 2023

Github, generate report

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 24, 2023

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/87515e8_2023123322/reports/diff/intellij-community/index.html.

Null pointer exception is expected because their is no method body and it is a class.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 24, 2023

R-2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/87515e8_2023161333/reports/diff/index.html

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 24, 2023

@romani report geneated

romani
romani approved these changes Jul 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge.

Please add this PR to our issue of minor bad effects.

@romani romani requested review from Vyom-Yadav and rdiachenko July 26, 2023 05:52
rdiachenko
rdiachenko approved these changes Jul 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko rdiachenko assigned Vyom-Yadav and unassigned rdiachenko Jul 26, 2023
Vyom-Yadav
Vyom-Yadav approved these changes Aug 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Vyom-Yadav Vyom-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vyom-Yadav Vyom-Yadav assigned romani and unassigned Vyom-Yadav Aug 1, 2023
This was referenced Aug 2, 2023
Closed
Closed
@romani romani merged commit 5e19b20 into checkstyle:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

+1 more reviewer

@Vyom-Yadav Vyom-Yadav Vyom-Yadav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@romani romani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kevin222004 @romani @rdiachenko @Vyom-Yadav