Issue #13321: Kill mutation for DetectorOption by Kevin222004 · Pull Request #13412 · checkstyle/checkstyle

Kevin222004 · 2023-07-20T05:51:21Z

Issue #13321: Kill mutation for DetectorOption

Mutation

checkstyle/config/pitest-suppressions/pitest-regexp-suppressions.xml

Lines 3 to 10 in 2335aba

    
           <mutation unstable="false"> 
        
             <sourceFile>DetectorOptions.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.regexp.DetectorOptions</mutatedClass> 
        
             <mutatedMethod>&lt;init&gt;</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator> 
        
             <description>Removed assignment to member variable message</description> 
        
             <lineContent>private String message = &quot;&quot;;</lineContent> 
        
           </mutation>

Explaination

It is some inner class, and all fields already not initialized, so with such update we do implementation consistent.

All the time whenever we use this message field in check we use the build method and the build method is

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/regexp/DetectorOptions.java

Lines 246 to 250 in 2335aba

    
           public DetectorOptions build() { 
        
               message = Optional.ofNullable(message).orElse(""); 
        
               suppressor = Optional.ofNullable(suppressor).orElse(NeverSuppress.INSTANCE); 
        
               pattern = Optional.ofNullable(format).map(this::createPattern).orElse(null); 
        
               return DetectorOptions.this;

message is set like message = Optional.ofNullable(message).orElse(""); so if the message is null then it will be "" empty string so removal will not make issue

Regression :-

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/af6965cd82853221b89f6ba3b81b996a/raw/89f2f0efe08703af1c3c9b9f3b5d2330a064dea3/RegexpSingleline.xml
Diff Regression projects: https://gist.githubusercontent.com/Kevin222004/9600f179b602d4c971bdb0a050099005/raw/360a95ed7bb60d7a0956e531199d484c4d6f6617/test-projects.properties
Report label: Regression-2

Kevin222004 · 2023-07-20T06:53:22Z

Github, generate report

github-actions · 2023-07-20T07:14:52Z

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/5607849454

Kevin222004 · 2023-07-20T08:28:57Z

Github, generate report

github-actions · 2023-07-20T09:17:06Z

Regression-1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/5b5ad92_2023091626/reports/diff/index.html

Kevin222004 · 2023-07-20T11:17:35Z

Github, generate report

github-actions · 2023-07-20T11:27:42Z

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/5610322336

Kevin222004 · 2023-07-21T15:11:19Z

Github, generate report

github-actions · 2023-07-21T15:18:58Z

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/5623832787

rdiachenko

lgtm

romani

Items

...pycrawl/tools/checkstyle/checks/regexp/regexpsingleline/InputRegexpSinglelineSemantic10.java

romani

Items:

src/main/java/com/puppycrawl/tools/checkstyle/checks/regexp/DetectorOptions.java

romani

Ok to merge

Vyom-Yadav

LGTM!

Kevin222004 force-pushed the do1 branch from d78414f to 5b5ad92 Compare July 20, 2023 06:59

rdiachenko approved these changes Jul 26, 2023

View reviewed changes

rdiachenko assigned Vyom-Yadav Jul 26, 2023

romani requested changes Jul 29, 2023

View reviewed changes

...pycrawl/tools/checkstyle/checks/regexp/regexpsingleline/InputRegexpSinglelineSemantic10.java Outdated Show resolved Hide resolved

Kevin222004 force-pushed the do1 branch from 5b5ad92 to 68fdb6b Compare July 30, 2023 09:59

romani requested changes Jul 30, 2023

View reviewed changes

src/main/java/com/puppycrawl/tools/checkstyle/checks/regexp/DetectorOptions.java Show resolved Hide resolved

Kevin222004 mentioned this pull request Aug 5, 2023

Resolve pitest survivals in modules - 3 #13501

Closed

61 tasks

Issue checkstyle#13321: Kill mutation for DetectorOption

042056e

Kevin222004 force-pushed the do1 branch from 68fdb6b to 042056e Compare August 7, 2023 16:47

romani approved these changes Aug 9, 2023

View reviewed changes

romani requested a review from Vyom-Yadav August 9, 2023 00:30

Vyom-Yadav approved these changes Aug 9, 2023

View reviewed changes

Vyom-Yadav assigned romani and unassigned Vyom-Yadav Aug 9, 2023

romani merged commit 805fa20 into checkstyle:master Aug 9, 2023

	<mutation unstable="false">
	<sourceFile>DetectorOptions.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.regexp.DetectorOptions</mutatedClass>
	<mutatedMethod><init></mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
	<description>Removed assignment to member variable message</description>
	<lineContent>private String message = "";</lineContent>
	</mutation>

	public DetectorOptions build() {
	message = Optional.ofNullable(message).orElse("");
	suppressor = Optional.ofNullable(suppressor).orElse(NeverSuppress.INSTANCE);
	pattern = Optional.ofNullable(format).map(this::createPattern).orElse(null);
	return DetectorOptions.this;

Uh oh!

Conversation

Kevin222004 commented Jul 20, 2023 • edited by romani Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mutation

Explaination

Regression :-

Uh oh!

Kevin222004 commented Jul 20, 2023

Uh oh!

github-actions bot commented Jul 20, 2023

Uh oh!

Kevin222004 commented Jul 20, 2023

Uh oh!

github-actions bot commented Jul 20, 2023

Uh oh!

Kevin222004 commented Jul 20, 2023

Uh oh!

github-actions bot commented Jul 20, 2023

Uh oh!

Kevin222004 commented Jul 21, 2023

Uh oh!

github-actions bot commented Jul 21, 2023

Uh oh!

rdiachenko left a comment

Choose a reason for hiding this comment

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Vyom-Yadav left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kevin222004 commented Jul 20, 2023 •

edited by romani

Loading