Issue #13321: Kill mutation for Xpath profile by Kevin222004 · Pull Request #13401 · checkstyle/checkstyle

Kevin222004 · 2023-07-16T06:55:06Z

Issue #13321: Kill mutation for Xpath profile

Mutation

checkstyle/config/pitest-suppressions/pitest-xpath-suppressions.xml

Lines 57 to 73 in 89e3ffc

    
           <mutation unstable="false"> 
        
             <sourceFile>DescendantIterator.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.xpath.iterators.DescendantIterator</mutatedClass> 
        
             <mutatedMethod>&lt;init&gt;</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator> 
        
             <description>Removed assignment to member variable descendantEnum</description> 
        
             <lineContent>descendantEnum = null;</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>FollowingIterator.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.xpath.iterators.FollowingIterator</mutatedClass> 
        
             <mutatedMethod>&lt;init&gt;</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator> 
        
             <description>Removed assignment to member variable descendantEnum</description> 
        
             <lineContent>descendantEnum = null;</lineContent> 
        
           </mutation>

and

checkstyle/config/pitest-suppressions/pitest-xpath-suppressions.xml

Lines 84 to 91 in 89e3ffc

    
           <mutation unstable="false"> 
        
             <sourceFile>PrecedingIterator.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.xpath.iterators.PrecedingIterator</mutatedClass> 
        
             <mutatedMethod>&lt;init&gt;</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator> 
        
             <description>Removed assignment to member variable descendantEnum</description> 
        
             <lineContent>descendantEnum = null;</lineContent> 
        
           </mutation>

Explaination

All are default value and they are in constructor

Vyom-Yadav

LGTM! Those are the default values.

CI Failure is unrelated.

romani

Ok to merge.

Just removal of null assignments that are happening already before ctor execution

rdiachenko

lgtm

rdiachenko · 2023-07-22T15:05:30Z

rebased

nrmancuso · 2023-07-29T18:02:45Z

@romani looks like @Vyom-Yadav already reviewed and approved, I will merge this

Kevin222004 mentioned this pull request Jul 16, 2023

Resolve pitest survivals in modules - 2 #13321

Closed

41 tasks

Kevin222004 force-pushed the xp2 branch from 25583e4 to a6c3eab Compare July 16, 2023 08:19

Vyom-Yadav self-requested a review July 16, 2023 10:43

Vyom-Yadav approved these changes Jul 16, 2023

View reviewed changes

Vyom-Yadav requested a review from romani July 16, 2023 10:44

Vyom-Yadav assigned romani Jul 16, 2023

romani approved these changes Jul 21, 2023

View reviewed changes

romani assigned rdiachenko and unassigned romani Jul 21, 2023

romani requested a review from rdiachenko July 21, 2023 15:52

rdiachenko approved these changes Jul 22, 2023

View reviewed changes

Issue checkstyle#13321: Kill mutation for Xpath profile

f6738a2

rdiachenko force-pushed the xp2 branch from a6c3eab to f6738a2 Compare July 22, 2023 15:05

romani assigned Vyom-Yadav and unassigned rdiachenko Jul 22, 2023

nrmancuso approved these changes Jul 29, 2023

View reviewed changes

nrmancuso merged commit f5cbb24 into checkstyle:master Jul 29, 2023

This was referenced Aug 2, 2023

storage Kevin222004/GitHub-action#3

Closed

Resolve pitest survivals in modules - 3 #13501

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Issue #13321: Kill mutation for Xpath profile#13401

Issue #13321: Kill mutation for Xpath profile#13401
nrmancuso merged 1 commit intocheckstyle:masterfrom
Kevin222004:xp2

Kevin222004 commented Jul 16, 2023

Uh oh!

Vyom-Yadav left a comment

Uh oh!

romani left a comment

Uh oh!

rdiachenko left a comment

Uh oh!

rdiachenko commented Jul 22, 2023

Uh oh!

nrmancuso commented Jul 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	<mutation unstable="false">
	<sourceFile>DescendantIterator.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.xpath.iterators.DescendantIterator</mutatedClass>
	<mutatedMethod><init></mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
	<description>Removed assignment to member variable descendantEnum</description>
	<lineContent>descendantEnum = null;</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>FollowingIterator.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.xpath.iterators.FollowingIterator</mutatedClass>
	<mutatedMethod><init></mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
	<description>Removed assignment to member variable descendantEnum</description>
	<lineContent>descendantEnum = null;</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>PrecedingIterator.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.xpath.iterators.PrecedingIterator</mutatedClass>
	<mutatedMethod><init></mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
	<description>Removed assignment to member variable descendantEnum</description>
	<lineContent>descendantEnum = null;</lineContent>
	</mutation>

Uh oh!

Conversation

Kevin222004 commented Jul 16, 2023

Mutation

Explaination

Uh oh!

Vyom-Yadav left a comment

Choose a reason for hiding this comment

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

rdiachenko left a comment

Choose a reason for hiding this comment

Uh oh!

rdiachenko commented Jul 22, 2023

Uh oh!

nrmancuso commented Jul 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants