Issue #13501: Kill mutation for RegexpCheck-3 by Kevin222004 · Pull Request #13383 · checkstyle/checkstyle

Kevin222004 · 2023-07-09T08:46:02Z

Issue #13501: Kill mutation for RegexpCheck-3

Check

https://checkstyle.org/checks/regexp/regexp.html#Regexp

Mutation

checkstyle/config/pitest-suppressions/pitest-regexp-suppressions.xml

Lines 21 to 55 in 4b7a2df

    
           <mutation unstable="false"> 
        
             <sourceFile>RegexpCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.regexp.RegexpCheck</mutatedClass> 
        
             <mutatedMethod>beginTree</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator> 
        
             <description>Removed assignment to member variable errorCount</description> 
        
             <lineContent>errorCount = 0;</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>RegexpCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.regexp.RegexpCheck</mutatedClass> 
        
             <mutatedMethod>beginTree</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator> 
        
             <description>Removed assignment to member variable matchCount</description> 
        
             <lineContent>matchCount = 0;</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>RegexpCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.regexp.RegexpCheck</mutatedClass> 
        
             <mutatedMethod>isIgnore</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator> 
        
             <description>removed call to com/puppycrawl/tools/checkstyle/api/FileText::lineColumn</description> 
        
             <lineContent>end = text.lineColumn(0);</lineContent> 
        
           </mutation> 
        
           <mutation unstable="false"> 
        
             <sourceFile>RegexpCheck.java</sourceFile> 
        
             <mutatedClass>com.puppycrawl.tools.checkstyle.checks.regexp.RegexpCheck</mutatedClass> 
        
             <mutatedMethod>setDuplicateLimit</mutatedMethod> 
        
             <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator> 
        
             <description>Removed assignment to member variable duplicateLimit</description> 
        
             <lineContent>this.duplicateLimit = duplicateLimit;</lineContent> 
        
           </mutation>

Explaination

Test added

romani

Items

src/test/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpCheckTest.java

src/test/resources/com/puppycrawl/tools/checkstyle/checks/regexp/regexp/InputRegexpCheckB4.java

Kevin222004 · 2023-07-31T06:42:55Z

Please avoid ci I will resolve them

please confirm the method looks good or not

src/test/java/com/puppycrawl/tools/checkstyle/AbstractModuleTestSupport.java

romani

Apply for all cases like this:

src/test/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpCheckTest.java

romani · 2023-08-01T02:06:10Z

Waiting for green CI

Kevin222004 · 2023-08-02T13:09:36Z

#13383 (comment)

@romani done failure not related to ci

romani

Ok to merge

Kevin222004 mentioned this pull request Jul 9, 2023

Resolve pitest survivals in modules - 2 #13321

Closed

41 tasks

romani requested changes Jul 9, 2023

View reviewed changes

src/test/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpCheckTest.java Outdated Show resolved Hide resolved

src/test/resources/com/puppycrawl/tools/checkstyle/checks/regexp/regexp/InputRegexpCheckB4.java Outdated Show resolved Hide resolved

Kevin222004 force-pushed the regexp3 branch 2 times, most recently from 60b5bc0 to 39f2e19 Compare July 14, 2023 10:10

Kevin222004 force-pushed the regexp3 branch from 39f2e19 to c754256 Compare July 20, 2023 04:32

romani self-assigned this Jul 29, 2023

Kevin222004 force-pushed the regexp3 branch from c754256 to 09558f9 Compare July 31, 2023 06:38

Kevin222004 commented Jul 31, 2023

View reviewed changes

src/test/java/com/puppycrawl/tools/checkstyle/AbstractModuleTestSupport.java Outdated Show resolved Hide resolved

Kevin222004 force-pushed the regexp3 branch from 09558f9 to 7121a89 Compare July 31, 2023 11:58

romani requested changes Jul 31, 2023

View reviewed changes

src/test/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpCheckTest.java Outdated Show resolved Hide resolved

Kevin222004 force-pushed the regexp3 branch from 7121a89 to 25643ec Compare July 31, 2023 17:50

This was referenced Aug 2, 2023

storage Kevin222004/GitHub-action#3

Closed

Resolve pitest survivals in modules - 3 #13501

Closed

Kevin222004 changed the title ~~Issue #13321: Kill mutation for RegexpCheck-3~~ Issue #13501: Kill mutation for RegexpCheck-3 Aug 2, 2023

Kevin222004 force-pushed the regexp3 branch from 25643ec to 7b819ba Compare August 2, 2023 09:55

Issue checkstyle#13501: Kill mutation for RegexpCheck-3

5740ea0

Kevin222004 force-pushed the regexp3 branch from 7b819ba to 5740ea0 Compare August 2, 2023 11:59

romani approved these changes Aug 2, 2023

View reviewed changes

romani merged commit 19b2594 into checkstyle:master Aug 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Issue #13501: Kill mutation for RegexpCheck-3#13383

Issue #13501: Kill mutation for RegexpCheck-3#13383
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:regexp3

Kevin222004 commented Jul 9, 2023 •

edited

Loading

Uh oh!

romani left a comment

Uh oh!

Uh oh!

Uh oh!

Kevin222004 commented Jul 31, 2023

Uh oh!

Uh oh!

romani left a comment

Uh oh!

Uh oh!

romani commented Aug 1, 2023

Uh oh!

Kevin222004 commented Aug 2, 2023

Uh oh!

romani left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	<mutation unstable="false">
	<sourceFile>RegexpCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.regexp.RegexpCheck</mutatedClass>
	<mutatedMethod>beginTree</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
	<description>Removed assignment to member variable errorCount</description>
	<lineContent>errorCount = 0;</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>RegexpCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.regexp.RegexpCheck</mutatedClass>
	<mutatedMethod>beginTree</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
	<description>Removed assignment to member variable matchCount</description>
	<lineContent>matchCount = 0;</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>RegexpCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.regexp.RegexpCheck</mutatedClass>
	<mutatedMethod>isIgnore</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
	<description>removed call to com/puppycrawl/tools/checkstyle/api/FileText::lineColumn</description>
	<lineContent>end = text.lineColumn(0);</lineContent>
	</mutation>

	<mutation unstable="false">
	<sourceFile>RegexpCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.regexp.RegexpCheck</mutatedClass>
	<mutatedMethod>setDuplicateLimit</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.MemberVariableMutator</mutator>
	<description>Removed assignment to member variable duplicateLimit</description>
	<lineContent>this.duplicateLimit = duplicateLimit;</lineContent>
	</mutation>

Uh oh!

Conversation

Kevin222004 commented Jul 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Check

Mutation

Explaination

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Kevin222004 commented Jul 31, 2023

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romani commented Aug 1, 2023

Uh oh!

Kevin222004 commented Aug 2, 2023

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Kevin222004 commented Jul 9, 2023 •

edited

Loading