Skip to content

Issue #13321: Kill mutation for pitest-utils profile#13379

Merged
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:ut
Jul 21, 2023
Merged

Issue #13321: Kill mutation for pitest-utils profile#13379
romani merged 1 commit intocheckstyle:masterfrom
Kevin222004:ut

Conversation

@Kevin222004
Copy link
Copy Markdown
Contributor

@Kevin222004 Kevin222004 commented Jul 8, 2023 •
edited
Loading

Issue #13321: Kill mutation for pitest-utils profile

@romani
Copy link
Copy Markdown
Member

romani commented Jul 9, 2023

Adding all in not good option, as it will make execution to be hours. Please keep adding checks tests one by one to keep execution time minimized.

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 9, 2023

Yes this is just for testing purpose i am not going to add all

@Kevin222004 Kevin222004 force-pushed the ut branch 2 times, most recently from 445df2f to c3319f1 Compare July 20, 2023 22:27
@Kevin222004 Kevin222004 changed the title minor: Added all the check test to pitest-utils profile Issue #13321: Kill mutation for pitest-utils profile Jul 20, 2023
romani
romani requested changes Jul 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

src/test/resources/com/puppycrawl/tools/checkstyle/utils/checkutil/InputCheckUtil3.java Outdated
// nesting == 2
if (true) {
if (true) {
if (true) { // violation
Copy link
Copy Markdown
Member

@romani romani Jul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use message for each violation

Copy link
Copy Markdown
Contributor Author

@Kevin222004 Kevin222004 Jul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Kevin222004 Kevin222004 mentioned this pull request Jul 21, 2023
Closed
41 tasks
@Kevin222004 Kevin222004 marked this pull request as ready for review July 21, 2023 07:20
@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 21, 2023

Please re-run failed ci
semaphore is also not looking related to changes

@Kevin222004
Copy link
Copy Markdown
Contributor Author

Kevin222004 commented Jul 21, 2023 •
edited
Loading

Failure of Semaphore

[INFO] Across all seeds:18:04
[INFO] com.puppycrawl.tools.checkstyle.checks.whitespace.SingleSpaceSeparatorCheckTest#testNoStackoverflowError18:04
[INFO] Test results can be found at: 18:04
[INFO] file:///home/semaphore/checkstyle/.nondex/mqPUyJg3YLld6jAMyRVk7sXkJs4gRpxIwGKZagQ7HkI=/test_results.html18:04
[INFO] [NonDex] The id of this run is: mqPUyJg3YLld6jAMyRVk7sXkJs4gRpxIwGKZagQ7HkI=18:04
[INFO] ------------------------------------------------------------------------18:04
[INFO] BUILD FAILURE18:04
[INFO] ------------------------------------------------------------------------18:04
[INFO] Total time:  18:02 min18:04
[INFO] Finished at: 2023-07-21T07:11:03Z18:04
[INFO] ------------------------------------------------------------------------

I have faced [INFO] com.puppycrawl.tools.checkstyle.checks.whitespace.SingleSpaceSeparatorCheckTest#testNoStackoverflowError18:04 in my local many time as well from past 1 day. while generating reports

@romani
Copy link
Copy Markdown
Member

romani commented Jul 21, 2023

my local many time as well from past 1 day. while generating reports

strange, usually for report generation tool we skip tests execution.
I didnot not noticed, if continue to bother you, lets open sepate issue and discuss.

CIs are restarted.

romani
romani approved these changes Jul 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge.

@romani romani merged commit 0827624 into checkstyle:master Jul 21, 2023
This was referenced Aug 2, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kevin222004 @romani